Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): suport SET GLOBAL|SESSIOIN statement #1364

Merged

Conversation

aceforeverd
Copy link
Collaborator

close #1361

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@aceforeverd aceforeverd added this to the v0.5 milestone Mar 2, 2022
@aceforeverd aceforeverd self-assigned this Mar 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

Linux Test Report

     112 files       238 suites   43m 55s ⏱️
  8 620 tests   8 617 ✔️ 3 💤 0
12 752 runs  12 749 ✔️ 3 💤 0

Results for commit 40daa92.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

HybridSE Linux Test Report

       65 files       231 suites   7m 6s ⏱️
19 156 tests 19 156 ✔️ 0 💤 0

Results for commit 40daa92.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

HybridSE Mac Test Report

       65 files       231 suites   6m 42s ⏱️
19 156 tests 19 156 ✔️ 0 💤 0

Results for commit 40daa92.

♻️ This comment has been updated with latest results.

@aceforeverd aceforeverd added the enhancement New feature or request label Mar 5, 2022
@aceforeverd aceforeverd force-pushed the feat/1361-set-globalsession-stmt branch from dcba0ea to 40daa92 Compare March 8, 2022 14:57
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1364 (40daa92) into main (62b5157) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1364      +/-   ##
============================================
- Coverage     65.48%   65.48%   -0.01%     
  Complexity      236      236              
============================================
  Files           571      571              
  Lines        106939   106952      +13     
  Branches        859      859              
============================================
+ Hits          70034    70040       +6     
- Misses        36753    36760       +7     
  Partials        152      152              
Impacted Files Coverage Δ
hybridse/src/planv2/ast_node_converter.cc 94.17% <100.00%> (+0.05%) ⬆️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/sdk/db_sdk.cc 61.81% <0.00%> (-1.22%) ⬇️
src/catalog/sdk_catalog.cc 73.40% <0.00%> (-1.07%) ⬇️
src/sdk/sql_cluster_router.cc 38.12% <0.00%> (-0.36%) ⬇️
src/zk/zk_client.cc 82.92% <0.00%> (-0.28%) ⬇️
src/catalog/tablet_catalog.cc 69.81% <0.00%> (ø)
src/tablet/tablet_impl.cc 37.90% <0.00%> (+0.05%) ⬆️
src/nameserver/name_server_impl.cc 37.61% <0.00%> (+0.05%) ⬆️
src/client/tablet_client.cc 35.58% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b5157...40daa92. Read the comment docs.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 0601201 into 4paradigm:main Mar 9, 2022
@aceforeverd aceforeverd deleted the feat/1361-set-globalsession-stmt branch March 9, 2022 06:29
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support SET GLOBAL|SESSION xx = val syntax
3 participants