feat: support set global variable #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dl239
reviewed
Mar 2, 2022
dl239
reviewed
Mar 2, 2022
dl239
reviewed
Mar 2, 2022
dl239
reviewed
Mar 2, 2022
keyu813
force-pushed
the
issue1257_
branch
2 times, most recently
from
2722219
to
246c135
Compare
Codecov Report
@@ Coverage Diff @@
## main #1359 +/- ##
=========================================
Coverage 66.03% 66.04%
Complexity 277 277
=========================================
Files 571 571
Lines 107721 107801 +80
Branches 904 904
=========================================
+ Hits 71136 71196 +60
- Misses 36393 36413 +20
Partials 192 192
Continue to review full report at Codecov.
|
aceforeverd
reviewed
Mar 11, 2022
dl239
reviewed
Mar 14, 2022
dl239
reviewed
Mar 14, 2022
aceforeverd
requested changes
Mar 14, 2022
src/sdk/sql_cluster_test.cc
Outdated
| tables.clear(); | ||
|
|
||
| ::hybridse::sdk::Status status; | ||
| std::string sql = "set @@global.enable_trace='true';"; |
There was a problem hiding this comment.
test SET GLOBAL as well
|
PR review meeting note:
|
aceforeverd
reviewed
Mar 16, 2022
added 13 commits
March 16, 2022 14:52
added 4 commits
March 16, 2022 14:55
aceforeverd
approved these changes
Mar 16, 2022
dl239
reviewed
Mar 16, 2022
| @@ -96,6 +97,11 @@ bool ClusterSDK::TriggerNotify() const { | |||
| return zk_client_->Increment(notify_path_); | |||
| } | |||
|
|
|||
| bool ClusterSDK::GlobalVarNotify() const { | |||
| LOG(INFO) << "Global variable changed trigger notify node"; | |||
dl239
reviewed
Mar 16, 2022
| @@ -123,6 +123,7 @@ class DBSDK { | |||
| std::string* msg); | |||
| std::vector<std::shared_ptr<hybridse::sdk::ProcedureInfo>> GetProcedureInfo(std::string* msg); | |||
| virtual bool TriggerNotify() const = 0; | |||
| virtual bool GlobalVarNotify() const = 0; | |||
There was a problem hiding this comment.
Call TriggerNotify as different notify_type. can do later
dl239
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature:
support set@@global.xxx = xxx & set GLOBAL xxx = xxx for Add global variable table #1257