Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support window union with unsaferow opt #1312

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added the enhancement New feature or request label Feb 24, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Feb 24, 2022
@tobegit3hub tobegit3hub self-assigned this Feb 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2022

Linux Test Report

     105 files       231 suites   43m 28s ⏱️
  8 614 tests   8 611 ✔️ 3 💤 0
12 741 runs  12 738 ✔️ 3 💤 0

Results for commit 8f92e06.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1312 (8f92e06) into main (aaf9803) will decrease coverage by 0.01%.
The diff coverage is 53.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1312      +/-   ##
============================================
- Coverage     65.53%   65.52%   -0.02%     
  Complexity      222      222              
============================================
  Files           570      570              
  Lines        106449   106548      +99     
  Branches        855      855              
============================================
+ Hits          69766    69813      +47     
- Misses        36537    36589      +52     
  Partials        146      146              
Impacted Files Coverage Δ
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% <0.00%> (ø)
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 63.68% <33.33%> (-0.52%) ⬇️
..._4paradigm/openmldb/batch/utils/HybridseUtil.scala 60.90% <38.46%> (-2.44%) ⬇️
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 67.19% <44.82%> (-6.70%) ⬇️
..._4paradigm/openmldb/batch/utils/SparkRowUtil.scala 58.53% <59.09%> (-3.37%) ⬇️
hybridse/src/codec/fe_row_codec.cc 76.57% <100.00%> (+0.07%) ⬆️
...4paradigm/openmldb/batch/OpenmldbBatchConfig.scala 85.36% <100.00%> (+0.36%) ⬆️
...4paradigm/openmldb/batch/api/OpenmldbSession.scala 57.57% <100.00%> (+4.76%) ⬆️
...paradigm/openmldb/batch/nodes/SelectIntoPlan.scala 60.00% <0.00%> (-13.34%) ⬇️
..._4paradigm/openmldb/batch/nodes/LoadDataPlan.scala 53.68% <0.00%> (-2.11%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7fb76...8f92e06. Read the comment docs.

@tobegit3hub tobegit3hub merged commit b6dfacb into 4paradigm:main Mar 1, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable UnsafeRowOpt for window with union will get incorrect result
3 participants