Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix unsaferow for window #1298

Merged
merged 5 commits into from
Feb 24, 2022
Merged

feat: fix unsaferow for window #1298

merged 5 commits into from
Feb 24, 2022

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added bug Something isn't working enhancement New feature or request labels Feb 23, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Feb 23, 2022
@tobegit3hub tobegit3hub self-assigned this Feb 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022

Linux Test Report

     104 files       230 suites   39m 35s ⏱️
  8 613 tests   8 610 ✔️ 3 💤 0
12 740 runs  12 737 ✔️ 3 💤 0

Results for commit e8ddb5a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022

HybridSE Linux Test Report

       65 files       231 suites   6m 29s ⏱️
19 138 tests 19 138 ✔️ 0 💤 0

Results for commit e8ddb5a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022

HybridSE Mac Test Report

       65 files       231 suites   7m 7s ⏱️
19 138 tests 19 138 ✔️ 0 💤 0

Results for commit e8ddb5a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1298 (e8ddb5a) into main (836b341) will increase coverage by 0.01%.
The diff coverage is 60.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1298      +/-   ##
============================================
+ Coverage     65.52%   65.54%   +0.01%     
  Complexity      222      222              
============================================
  Files           570      570              
  Lines        106352   106457     +105     
  Branches        855      833      -22     
============================================
+ Hits          69683    69773      +90     
- Misses        36523    36538      +15     
  Partials        146      146              
Impacted Files Coverage Δ
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 73.86% <ø> (-0.03%) ⬇️
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 63.68% <33.33%> (-0.52%) ⬇️
..._4paradigm/openmldb/batch/utils/SparkRowUtil.scala 58.53% <59.09%> (-3.37%) ⬇️
hybridse/src/codec/fe_row_codec.cc 76.57% <100.00%> (+0.07%) ⬆️
...4paradigm/openmldb/batch/OpenmldbBatchConfig.scala 85.36% <100.00%> (+0.36%) ⬆️
...paradigm/openmldb/batch/nodes/SelectIntoPlan.scala 60.00% <0.00%> (-13.34%) ⬇️
..._4paradigm/openmldb/batch/nodes/LoadDataPlan.scala 53.68% <0.00%> (-2.11%) ⬇️
src/rpc/rpc_client.h 64.86% <0.00%> (-1.36%) ⬇️
src/tablet/tablet_impl.cc 37.67% <0.00%> (-0.26%) ⬇️
src/nameserver/name_server_impl.cc 37.18% <0.00%> (-0.01%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836b341...e8ddb5a. Read the comment docs.

@vagetablechicken vagetablechicken merged commit 2e7fb76 into 4paradigm:main Feb 24, 2022
@tobegit3hub tobegit3hub deleted the feat/fix_unsaferow_for_window branch February 24, 2022 10:02
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsafeRowOpt may output incorrect result for SQL with string columns
3 participants