-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add check for taskmanager config #1262
Merged
vagetablechicken
merged 5 commits into
4paradigm:main
from
tobegit3hub:feat/taskmanager_add_check_for_config
Feb 21, 2022
Merged
feat: add check for taskmanager config #1262
vagetablechicken
merged 5 commits into
4paradigm:main
from
tobegit3hub:feat/taskmanager_add_check_for_config
Feb 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tobegit3hub
commented
Feb 18, 2022
•
edited
Loading
edited
- Resolve when spark.master = yarn, offline.data.prefix = hdfs://*******. #1068 .
- Resolve Add check for config of TaskManager #1252 .
- Resolve Fail to stop yarn job in cluster mode and connect the incorrect Yarn cluster #1088 .
Codecov Report
@@ Coverage Diff @@
## main #1262 +/- ##
============================================
- Coverage 65.68% 65.52% -0.17%
+ Complexity 253 222 -31
============================================
Files 569 570 +1
Lines 106290 106345 +55
Branches 817 843 +26
============================================
- Hits 69820 69685 -135
- Misses 36307 36514 +207
+ Partials 163 146 -17
Continue to review full report at Codecov.
|
vagetablechicken
approved these changes
Feb 21, 2022
aceforeverd
reviewed
Feb 21, 2022
...ldb-taskmanager/src/test/java/com/_4paradigm/openmldb/taskmanager/TestTaskManagerClient.java
Show resolved
Hide resolved
aceforeverd
approved these changes
Feb 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.