Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: taskmanager will find the local batchjob jar if not configured #1250

Merged
merged 3 commits into from
Feb 18, 2022
Merged

feat: taskmanager will find the local batchjob jar if not configured #1250

merged 3 commits into from
Feb 18, 2022

Conversation

tobegit3hub
Copy link
Collaborator

  • Remove the config of batchjob.jar.path with specified version in TaskManager config file
  • Support automatically finding batchjob jar with added util function

After merged, we do not need to update the version in TaskManager config file.

@tobegit3hub tobegit3hub added the enhancement New feature or request label Feb 17, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Feb 17, 2022
@tobegit3hub tobegit3hub self-assigned this Feb 17, 2022
@tobegit3hub tobegit3hub changed the title feat: TaskManager will find the local batchjob jar if not configured feat: taskmanager will find the local batchjob jar if not configured Feb 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2022

Linux Test Report

     101 files       227 suites   43m 5s ⏱️
  8 592 tests   8 589 ✔️ 3 💤 0
12 716 runs  12 713 ✔️ 3 💤 0

Results for commit ae9a830.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1250 (ae9a830) into main (ea66012) will decrease coverage by 0.16%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1250      +/-   ##
============================================
- Coverage     65.85%   65.68%   -0.17%     
+ Complexity      278      252      -26     
============================================
  Files           568      569       +1     
  Lines        106254   106277      +23     
  Branches        810      817       +7     
============================================
- Hits          69972    69813     -159     
- Misses        36099    36302     +203     
+ Partials        183      162      -21     
Impacted Files Coverage Δ
...openmldb/taskmanager/config/TaskManagerConfig.java 54.16% <33.33%> (-37.14%) ⬇️
...adigm/openmldb/taskmanager/util/BatchJobUtil.scala 41.17% <41.17%> (ø)
...openmldb/taskmanager/server/TaskManagerServer.java 50.00% <100.00%> (+1.28%) ⬆️
...adigm/openmldb/taskmanager/dao/JobIdGenerator.java 0.00% <0.00%> (-79.32%) ⬇️
...m/_4paradigm/openmldb/taskmanager/dao/JobInfo.java 0.00% <0.00%> (-64.45%) ⬇️
...m/_4paradigm/openmldb/taskmanager/LogManager.scala 0.00% <0.00%> (-57.15%) ⬇️
.../openmldb/taskmanager/spark/SparkJobListener.scala 0.00% <0.00%> (-57.15%) ⬇️
...m/openmldb/taskmanager/spark/SparkJobManager.scala 0.00% <0.00%> (-50.91%) ⬇️
...paradigm/openmldb/taskmanager/JobInfoManager.scala 13.76% <0.00%> (-27.53%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea66012...ae9a830. Read the comment docs.

Copy link
Collaborator

@HuilinWu2 HuilinWu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 489a393 into 4paradigm:main Feb 18, 2022
@lumianph lumianph mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants