-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: taskmanager will find the local batchjob jar if not configured #1250
feat: taskmanager will find the local batchjob jar if not configured #1250
Conversation
...nmldb-taskmanager/src/main/scala/com/_4paradigm/openmldb/taskmanager/util/BatchJobUtil.scala
Show resolved
Hide resolved
...nmldb-taskmanager/src/main/scala/com/_4paradigm/openmldb/taskmanager/util/BatchJobUtil.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1250 +/- ##
============================================
- Coverage 65.85% 65.68% -0.17%
+ Complexity 278 252 -26
============================================
Files 568 569 +1
Lines 106254 106277 +23
Branches 810 817 +7
============================================
- Hits 69972 69813 -159
- Misses 36099 36302 +203
+ Partials 183 162 -21
Continue to review full report at Codecov.
|
...-taskmanager/src/main/java/com/_4paradigm/openmldb/taskmanager/config/TaskManagerConfig.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
batchjob.jar.path
with specified version in TaskManager config fileAfter merged, we do not need to update the version in TaskManager config file.