Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support long ts type in csv loading #1237

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Feb 16, 2022

A part of #1170 fix.
A ts column supports Y-M-D H:m:S or long.
Different columns can have different format. But in one column, only one format(will use the first non-null value's format).

A ts column supports Y-M-D H:m:S or long.
Different columns can have different format. But in one column, only one format(will use the first non-null value's format).
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022

Linux Test Report

     101 files       227 suites   42m 1s ⏱️
  8 593 tests   8 590 ✔️ 3 💤 0
12 718 runs  12 715 ✔️ 3 💤 0

Results for commit 689ac30.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is little complex but works. Maybe refactor to add as a function later.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1237 (689ac30) into main (8da5f7d) will increase coverage by 0.01%.
The diff coverage is 83.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1237      +/-   ##
============================================
+ Coverage     65.84%   65.86%   +0.01%     
  Complexity      278      278              
============================================
  Files           568      568              
  Lines        106237   106254      +17     
  Branches        806      810       +4     
============================================
+ Hits          69957    69981      +24     
+ Misses        36097    36090       -7     
  Partials        183      183              
Impacted Files Coverage Δ
..._4paradigm/openmldb/batch/nodes/LoadDataPlan.scala 55.78% <83.78%> (+16.04%) ⬆️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/zk/zk_client.cc 82.92% <0.00%> (-1.09%) ⬇️
src/sdk/db_sdk.cc 60.00% <0.00%> (-0.61%) ⬇️
src/tablet/tablet_impl.cc 37.89% <0.00%> (+0.13%) ⬆️
src/catalog/tablet_catalog.cc 67.92% <0.00%> (+0.94%) ⬆️
..._4paradigm/openmldb/batch/utils/SparkRowUtil.scala 52.63% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da5f7d...689ac30. Read the comment docs.

@yabg-shuai666
Copy link
Contributor

LGMT

@yabg-shuai666 yabg-shuai666 self-requested a review February 17, 2022 07:34
@tobegit3hub tobegit3hub merged commit ea66012 into 4paradigm:main Feb 17, 2022
@vagetablechicken
Copy link
Collaborator Author

@lumianph lumianph linked an issue Feb 21, 2022 that may be closed by this pull request
@lumianph lumianph mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load csv file failed if schema set not null
3 participants