-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support long ts type in csv loading #1237
Conversation
A ts column supports Y-M-D H:m:S or long. Different columns can have different format. But in one column, only one format(will use the first non-null value's format).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is little complex but works. Maybe refactor to add as a function later.
Codecov Report
@@ Coverage Diff @@
## main #1237 +/- ##
============================================
+ Coverage 65.84% 65.86% +0.01%
Complexity 278 278
============================================
Files 568 568
Lines 106237 106254 +17
Branches 806 810 +4
============================================
+ Hits 69957 69981 +24
+ Misses 36097 36090 -7
Partials 183 183
Continue to review full report at Codecov.
|
LGMT |
A part of #1170 fix.
A ts column supports Y-M-D H:m:S or long.
Different columns can have different format. But in one column, only one format(will use the first non-null value's format).