Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update tablet client #1226

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Feb 15, 2022

@dl239 dl239 added the bug Something isn't working label Feb 15, 2022
@dl239 dl239 linked an issue Feb 15, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2022

Linux Test Report

     101 files       227 suites   41m 0s ⏱️
  8 592 tests   8 589 ✔️ 3 💤 0
12 717 runs  12 714 ✔️ 3 💤 0

Results for commit 1b1cd23.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1226 (1b1cd23) into main (8da5f7d) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1226      +/-   ##
============================================
- Coverage     65.84%   65.84%   -0.01%     
  Complexity      278      278              
============================================
  Files           568      568              
  Lines        106237   106240       +3     
  Branches        806      806              
============================================
  Hits          69957    69957              
- Misses        36097    36100       +3     
  Partials        183      183              
Impacted Files Coverage Δ
src/nameserver/name_server_impl.h 100.00% <ø> (ø)
src/nameserver/name_server_impl.cc 37.17% <80.00%> (+0.02%) ⬆️
src/tablet/tablet_impl.cc 37.73% <100.00%> (-0.03%) ⬇️
src/zk/zk_client.cc 82.65% <0.00%> (-1.36%) ⬇️
src/catalog/tablet_catalog.cc 67.92% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da5f7d...1b1cd23. Read the comment docs.

@vagetablechicken vagetablechicken merged commit 66bd3ee into 4paradigm:main Feb 17, 2022
@dl239 dl239 deleted the fix/update_client branch February 21, 2022 03:43
@lumianph lumianph mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tablet cannot get other tablet clients sometime
3 participants