-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lower()
and lcase()
#1192
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1192 +/- ##
=========================================
Coverage 42.91% 42.92%
Complexity 279 279
=========================================
Files 562 562
Lines 106006 106074 +68
Branches 983 985 +2
=========================================
+ Hits 45492 45527 +35
- Misses 60333 60364 +31
- Partials 181 183 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! @Liu-2001 Thank you for the contribution.
@wuyou10206 Add tests for lower() and lcase() function once the PR has been merged
LGTM
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds the
lcase()
andlower()
functions.What is the current behavior? (You can also link to an open issue here)
The two functions have not been implemented.
close built-in function: Support
lcase()
andlower()
#784What is the new behavior (if this is a feature change)?
These two functions convert all characters in a string into lower cases.