Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix git plugin and return version of openmldb-batch #1150

Merged
merged 1 commit into from
Feb 9, 2022
Merged

feat: fix git plugin and return version of openmldb-batch #1150

merged 1 commit into from
Feb 9, 2022

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub commented Jan 27, 2022

  • Fix to get the right version from git plugin.
  • Do not call spark.version() to avoid StackOverflow.

Here is the version from OpenmldbSession.version().

3.0.0
#Generated by Git-Commit-Id-Plugin
#Thu Jan 27 14:45:32 CST 2022
git.branch=main
git.build.host=mbp16.local
git.build.time=2022.01.27 14\:45\:32
[email protected]
git.build.user.name=tobe
git.build.version=0.5.0-SNAPSHOT
git.closest.tag.commit.count=623
git.closest.tag.name=v0.3.0
git.commit.id=632bbd41681229841ea0e32e8313906b90187c61
git.commit.id.abbrev=632bbd4
git.commit.id.describe=v0.3.0-623-g632bbd4-dirty
git.commit.id.describe-short=v0.3.0-623-dirty
git.commit.message.full=Merge pull request \#1132 from tobegit3hub/feat/simplfy_python_in_cmake\n\nfeat\: merge the similar commands to package python in macos and linux
git.commit.message.short=Merge pull request \#1132 from tobegit3hub/feat/simplfy_python_in_cmake
git.commit.time=2022.01.21 16\:29\:43
[email protected]
git.commit.user.name=tobe
git.dirty=true
[email protected]\:tobegit3hub/OpenMLDB.git
git.tags=

@tobegit3hub tobegit3hub added the enhancement New feature or request label Jan 27, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Jan 27, 2022
@tobegit3hub tobegit3hub self-assigned this Jan 27, 2022
@@ -438,6 +438,22 @@
<plugin>
<groupId>pl.project13.maven</groupId>
<artifactId>git-commit-id-plugin</artifactId>
<version>2.2.4</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a parent config in java/pom.xml, is that configuration not right ?
If so, we may tweak options there instead, so all modules shared the same config

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent plugin did not generated version file and we can not load the version. I will check the plugin config again and reuse the parent if possible.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022

Linux Test Report

     50 files       91 suites   9m 1s ⏱️
4 214 tests 4 211 ✔️ 3 💤 0
4 243 runs  4 240 ✔️ 3 💤 0

Results for commit ce53532.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1150 (ce53532) into main (2dc9901) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1150   +/-   ##
=========================================
  Coverage     42.91%   42.91%           
  Complexity      279      279           
=========================================
  Files           562      562           
  Lines        105999   105998    -1     
  Branches        983      983           
=========================================
  Hits          45492    45492           
+ Misses        60326    60325    -1     
  Partials        181      181           
Impacted Files Coverage Δ
...4paradigm/openmldb/batch/api/OpenmldbSession.scala 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc9901...ce53532. Read the comment docs.

Copy link
Collaborator

@HuilinWu2 HuilinWu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit d4c2b21 into 4paradigm:main Feb 9, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants