-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix git plugin and return version of openmldb-batch #1150
feat: fix git plugin and return version of openmldb-batch #1150
Conversation
@@ -438,6 +438,22 @@ | |||
<plugin> | |||
<groupId>pl.project13.maven</groupId> | |||
<artifactId>git-commit-id-plugin</artifactId> | |||
<version>2.2.4</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a parent config in java/pom.xml
, is that configuration not right ?
If so, we may tweak options there instead, so all modules shared the same config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent plugin did not generated version file and we can not load the version. I will check the plugin config again and reuse the parent if possible.
Codecov Report
@@ Coverage Diff @@
## main #1150 +/- ##
=========================================
Coverage 42.91% 42.91%
Complexity 279 279
=========================================
Files 562 562
Lines 105999 105998 -1
Branches 983 983
=========================================
Hits 45492 45492
+ Misses 60326 60325 -1
Partials 181 181
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spark.version()
to avoid StackOverflow.Here is the version from
OpenmldbSession.version()
.