Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: mv session_timeout to cluster router options and rename it #1941

Closed
vagetablechicken opened this issue Jun 9, 2022 · 0 comments · Fixed by #1965
Closed

refactor: mv session_timeout to cluster router options and rename it #1941

vagetablechicken opened this issue Jun 9, 2022 · 0 comments · Fixed by #1965
Labels
good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet

Comments

@vagetablechicken
Copy link
Collaborator

OpenMLDB/src/sdk/sql_router.h

Lines 39 to 44 in 5e242cf

struct BasicRouterOptions {
bool enable_debug = false;
uint32_t session_timeout = 2000;
uint32_t max_sql_cache_size = 10;
uint32_t request_timeout = 60000;
};

session_timeout is only for zookeeper settings. so it should be moved to SQLRouterOptions, and renamed to zk_session_timeout.

You should make src/sdk, java sdk and python sdk all pass.
@vagetablechicken vagetablechicken added the good first issue Good for newcomers label Jun 9, 2022
@aceforeverd aceforeverd added the storage-engine openmldb storage engine. nameserver & tablet label Jun 9, 2022
@auula auula mentioned this issue Jun 9, 2022
Closed
@vagetablechicken vagetablechicken changed the title refactor: session_timeout in sdk options refactor: mv session_timeout to cluster router options Jun 14, 2022
@vagetablechicken vagetablechicken changed the title refactor: mv session_timeout to cluster router options refactor: mv session_timeout to cluster router options and rename it Jun 14, 2022
@mangoGoForward mangoGoForward mentioned this issue Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Milestone
No milestone
2 participants
@aceforeverd @vagetablechicken