Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mv session_timeout to cluster router options and rename to it #1965

Merged
merged 1 commit into from
Jun 15, 2022
Merged

refactor: mv session_timeout to cluster router options and rename to it #1965

merged 1 commit into from
Jun 15, 2022

Conversation

mangoGoForward
Copy link
Contributor

@mangoGoForward mangoGoForward commented Jun 15, 2022

Signed-off-by: mango [email protected]

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Refactor

  • What is the current behavior? (You can also link to an open issue here)
    mv session_timeout to cluster router options and rename to zk_session_timeout
    Fixed refactor: mv session_timeout to cluster router options and rename it #1941

  • What is the new behavior (if this is a feature change)?
    None

@github-actions github-actions bot added api-server sdk openmldb java/python sdk labels Jun 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

Linux Test Report

       57 files       196 suites   49m 41s ⏱️
  8 961 tests   8 957 ✔️ 4 💤 0
13 187 runs  13 183 ✔️ 4 💤 0

Results for commit f748251.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

SDK Test Report

  75 files    75 suites   6m 14s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit f748251.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1965 (f748251) into main (19ab600) will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #1965      +/-   ##
============================================
+ Coverage     75.63%   75.65%   +0.02%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        116988   116987       -1     
  Branches       1022     1022              
============================================
+ Hits          88486    88511      +25     
+ Misses        28293    28267      -26     
  Partials        209      209              
Impacted Files Coverage Δ
src/apiserver/api_server_test.cc 0.00% <0.00%> (ø)
src/sdk/sql_router.h 33.33% <ø> (ø)
...paradigm/openmldb/sdk/impl/SqlClusterExecutor.java 57.89% <100.00%> (-0.21%) ⬇️
src/sdk/sql_cluster_router.cc 54.92% <100.00%> (ø)
src/zk/zk_client.cc 82.85% <0.00%> (-0.52%) ⬇️
src/nameserver/name_server_impl.cc 42.82% <0.00%> (+0.12%) ⬆️
src/tablet/tablet_impl.cc 59.54% <0.00%> (+0.19%) ⬆️
src/catalog/client_manager.cc 42.49% <0.00%> (+0.28%) ⬆️
.../query_response_time/deploy_query_response_time.cc 100.00% <0.00%> (+2.89%) ⬆️
src/rpc/rpc_client.h 89.18% <0.00%> (+4.05%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ab600...f748251. Read the comment docs.

@dl239 dl239 requested a review from vagetablechicken June 15, 2022 06:07
@vagetablechicken vagetablechicken merged commit 06255ca into 4paradigm:main Jun 15, 2022
@mangoGoForward mangoGoForward deleted the refactor/mv_session_timeout2_cluster branch June 15, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-server sdk openmldb java/python sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: mv session_timeout to cluster router options and rename it
3 participants