Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable notarization on macos #1380

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Enable notarization on macos #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e63e34
Upgrade electron-builder to 20.44.4 and electron-updater to 4.2.0
4ian Jan 15, 2020
44dbbd7
Add notarization for macOS
4ian Jan 15, 2020
adbcef8
Build zip for macOS on CircleCI
4ian Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
# Build GDevelop IDE
- run:
name: Build GDevelop IDE
command: cd newIDE/electron-app && npm run build -- --mac --win --linux tar.gz --publish=never
command: cd newIDE/electron-app && npm run build -- --mac zip --win --linux tar.gz --publish=never

- run:
name: Clean dist folder to keep only installers/binaries.
Expand Down
11 changes: 11 additions & 0 deletions newIDE/electron-app/.env.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Copy this file and rename it to ".env" and complete it.

# Fill the following variables for macOS notarization.
#
# Generate your "app-specific password" on appleid.apple.com
#
# See https://medium.com/@TwitterArchiveEraser/notarize-electron-apps-7a5f988406db
# and https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/
# for more information about notarization.
APPLEID=
APPLEIDPASS=
168 changes: 78 additions & 90 deletions newIDE/electron-app/app/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions newIDE/electron-app/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "gdevelop",
"productName": "GDevelop 5",
"description": "GDevelop 5 IDE running on the Electron runtime",
"version": "5.0.0-beta87",
"version": "5.0.0-beta88",
"author": "Florian Rival",
"license": "MIT",
"homepage": "http://gdevelop-app.com",
Expand All @@ -15,7 +15,7 @@
"electron-editor-context-menu": "^1.1.1",
"electron-is": "^2.4.0",
"electron-log": "^2.2.14",
"electron-updater": "^2.18.2",
"electron-updater": "4.2.0",
"fs-extra": "^3.0.1",
"jimp": "^0.2.28",
"live-server": "^1.2.0",
Expand Down
12 changes: 12 additions & 0 deletions newIDE/electron-app/build/entitlements.mac.inherit.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
<key>com.apple.security.cs.allow-dyld-environment-variables</key>
<true/>
</dict>
</plist>
Loading