Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(4allportal): support encoded characters for webdav events #254

Merged
merged 4 commits into from
May 17, 2024

Conversation

mstroecker
Copy link
Contributor

@mstroecker mstroecker commented Apr 19, 2024

The HTTPD-Log encodes characters outside the standard ASCII range as URL or hex-encoding. echo -e converts them to normal UTF-8 characters. The sed command converts URL encoding to hex-encoding (I'm unsure if this covers all encoding cases).

@mstroecker mstroecker added the bug Something isn't working label Apr 19, 2024
jpkraemer-mg
jpkraemer-mg previously approved these changes May 17, 2024
Copy link
Contributor

@jpkraemer-mg jpkraemer-mg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as intended

Copy link
Contributor

@jpkraemer-mg jpkraemer-mg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstroecker mstroecker merged commit 982c3c3 into main May 17, 2024
4 checks passed
@mstroecker mstroecker deleted the feat/webdav-support-encoded-chars branch May 17, 2024 17:09
Dominic-Beer pushed a commit that referenced this pull request Oct 22, 2024
* feat(4allportal): support encoded characters for webdav events

* chore(4allportal): update chart patch version

* chore(4allportal): update Chart version and docs

---------

Co-authored-by: Jean-Philippe Krämer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants