-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add limits page to docs #739
Conversation
Someone is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The copy could use a little elaboration in some sections.
- **Chrome:** ~2 MB (practically, you might encounter issues at around 2,000 characters). | ||
- **Firefox:** ~65,000 characters. | ||
- **Safari:** Generally has more restrictive limits (around 8,000 characters). | ||
- **IE/Edge:** Historically limited to 2,083 characters (IE), although Edge has relaxed this limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have sources on those numbers?
suggestion: One additional thing to mention is that the transport mechanism for URLs (social media, messengers etc) may have lower limits than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are actually different sources saying different things, those numbers are mentioned here I did a typo though, safari seems to be 80k.
@franky47 Thanks for the feedback, did some updates. Let me know what you think. By the way, do you think it is worth to display a warning in development if the limit of 2,000 is exceeded? If so I could work on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there might be some copy tweaks to do but I'll deal with that later, thanks!
Regarding the warning for max URL size, that sounds like a good idea, feel free to open a separate PR for this. You could log an error that points back to this documentation page actually, using the same error codes (see errors.ts
, 414 would be perfect for this).
Yeah something like that, will give it a go the next few days. |
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I added a new documentation page that informs users about some limitations when using nuqs.
If you would like to have anything changed/added, let me know.
Closes #731.