-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fix date inputs on Chrome #704
Conversation
@mehm8128 is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
That's interesting, it works on my end (Firefox 131), but you have to select the time too (as it's a datetime picker). What browser are you on that doesn't give you Screen.Recording.2024-10-24.at.10.00.47.movNote: I get the same behaviour with the preview deployment: |
Don't worry about the |
Thank you, I understand. This is my record trying to fill date with three methods.
Please try it on Chrome! lsWt8lEEMA.mp4fyi: my record in the preview environment for this PR. I successfully fill date and time explorer_6oTcRT2iIC.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, good catch, today I learned something. Thanks!
🎉 This PR is included in version 2.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I found the issue that on the docs Date inputs don't work well.
https://nuqs.47ng.com/docs/parsers/built-in#dates--timestamps
if we click
now
button, date successfully filled to the input and demo is working well, but if we it manually selecting the date and time, selected value is not filled.This is because we can't
valueAsDate
for the input tag withdatetime-local
, so I fixed it.I think this might be the same with the code below, but I don't know how I open the page of it so I can't debug it.
https://github.com/mehm8128/nuqs/blob/fix/docs-date-input/packages/docs/src/app/playground/_demos/parsers/page.tsx#L92-L109