Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shallow state #482

Merged
merged 8 commits into from
Feb 1, 2024
Merged

fix: Shallow state #482

merged 8 commits into from
Feb 1, 2024

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Jan 31, 2024

Set the history state to null as recommended in the Next.js docs for shallow routing.

Historically, while Next.js didn't support shallow routing (<14.1.0), maintaining the history state was the way to keep the app router state.

Closes #481.

As recommended in the Next.js docs for shallow routing.

Historically, while Next.js didn't support shallow routing (<14.1.0),
maintaining the history state was the way to keep
the app router state.
No need to pass pages-router specific code here,
as this branch now only runs in the app router context.
Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 3:17am

The fix only applies to GA versions.
@franky47 franky47 marked this pull request as ready for review February 1, 2024 03:10
@franky47 franky47 merged commit 50da148 into next Feb 1, 2024
15 checks passed
@franky47 franky47 deleted the fix/shallow-state branch February 1, 2024 03:20
Copy link

github-actions bot commented Feb 1, 2024

🎉 This PR is included in version 1.16.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Feb 1, 2024

🎉 This PR is included in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken in [email protected]
1 participant