-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala.js support #166
Add Scala.js support #166
Conversation
It doesn't look like the check failure is related to my changes, but I'm not familiar enough with the project to know for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍. Seems like the mdoc plugin now makes warnings fail the build. I'll try to fix it.
can you rebase against master, ci should be fixed |
the warning which makes the build fails is related to scala 2.13.3 |
76ca88b
to
5c249bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 95.68% 96.40% +0.71%
==========================================
Files 10 10
Lines 139 139
Branches 2 2
==========================================
+ Hits 133 134 +1
+ Misses 6 5 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , there is still this q though https://github.com/47degrees/scalacheck-toolbox/pull/166/files#r492057195
Running the tests now takes almost 2 hours compared to ~18 minutes before 🙀 The Scala.js tests run on node.js. Seems like they are by a magnitude slower especially on constrained CI runners. |
eb3e904
to
8ed7367
Compare
8ed7367
to
4d06140
Compare
Ok it seems like only Lines 26 to 27 in 9dc3e81
|
fine with me as long as it's only for js 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Dear maintainers, |
yes, we should be releasing 0.4.0 today 👍 |
This is an attempt to add
Scala.js
support toscalacheck-toolbox
so that downstream projects can use it for tests running on Scala.js.It adds Scala.js support to the
datetime
combinators
modules. I left support formagic
out for now as it would require changes in howblns.txt
gets loaded.Note that I've added sbt-projectmatrix for sane cross-building but I had to remove
sbt-modules
along the way.Fixes #25