-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for several types #69
Conversation
Hood benchmark comparison:
✔️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Float point comparison is brrroken. May be broken on Arrow too, we need to check.
@pakoito I thought I ported this from
PS: In Arrow it shouldn't be broken since we only have |
I'm going to move the float comparison issue to this #70 |
I still need to fix the Map codec before merge |
This is ready for review now @nomisRev @pakoito @fedefernandez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raulraja @pakoito @AdrianRaFo
Thoughts on my remark about the public API of JsNumber
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment, besides that looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Add more instances to encode and decode the following Arrow types:
Also, support for kotlin types:
and finally, support for Java types:
I have tested all these new types with complex models on the sample module
Note: If you note that an important type is missing and want to see it on the first release please let me know to add it here