Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule: guard-super-call #15

Merged
merged 3 commits into from
Feb 20, 2019
Merged

rule: guard-super-call #15

merged 3 commits into from
Feb 20, 2019

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented Feb 14, 2019 •
edited
Loading

Closes #5

TODO:

  • Update doc
  • Remove old code
  • Figure out how to get the jsdoc @customElement working (Maybe you can help @43081j)

@stramel stramel self-assigned this Feb 14, 2019
@stramel stramel requested a review from 43081j February 14, 2019 22:20
43081j
43081j requested changes Feb 18, 2019
View reviewed changes
Copy link
Owner

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also be catching missing super calls? if there isn't a member in the body, we should probably tell them to add a [guarded] super call

src/rules/guard-super-call.ts Outdated Show resolved Hide resolved
src/rules/guard-super-call.ts Outdated Show resolved Hide resolved
@stramel
Copy link
Collaborator Author

stramel commented Feb 18, 2019

should we also be catching missing super calls? if there isn't a member in the body, we should probably tell them to add a [guarded] super call

I was thinking that might be better as a separate rule. Also, kinda goes along with HTMLElement should NOT have super calls with the exception of constructor which should always have super if there is a superClass. (The constructor already exists as a default rule in eslint)

@43081j
Copy link
Owner

43081j commented Feb 18, 2019

when you get chance can you rebase onto master (or catch up). will take another look when im back on tomorrow

@stramel stramel force-pushed the ms/check-super-before-call branch from 7038f0e to 6d624fe Compare February 19, 2019 00:51
43081j
43081j approved these changes Feb 20, 2019
View reviewed changes
Copy link
Owner

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase this then it looks good to go i think? last change you did was to clean up the conditions a bit but i think that was all

@stramel stramel force-pushed the ms/check-super-before-call branch from 499c954 to 8e6ff17 Compare February 20, 2019 20:39
@stramel stramel merged commit 0fac33c into master Feb 20, 2019
@stramel stramel deleted the ms/check-super-before-call branch February 20, 2019 20:45
@stramel stramel mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

Assignees

@stramel stramel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stramel @43081j