Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› [Fix] ๊ณต๊ณ  ์ „์ฒด ์กฐํšŒ API์˜ ์ž˜๋ชป๋œ ์‘๋‹ต ์ˆ˜์ • #817

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

Kimhan-nah
Copy link
Member

๐Ÿ“Œ ๊ฐœ์š”

  • ๊ณต๊ณ  ์ „์ฒด ์กฐํšŒ API์˜ ์ž˜๋ชป๋œ ์‘๋‹ต์— ๋Œ€ํ•œ ์ˆ˜์ •

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • status -> isFinish ํ•„๋“œ๋ช… ์ˆ˜์ •
  • ๊ณต๊ณ  ์ „์ฒด ์กฐํšŒ์‹œ ์‚ญ์ œ๋œ ๊ณต๊ณ ๋Š” ํ•„ํ„ฐ๋งํ•˜์—ฌ ๋ณด๋‚ด์ง€ ์•Š๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. (isDeleted๊ฐ€ true์ธ ๊ณต๊ณ  ํ•„ํ„ฐ๋ง)
  • PageRequestDto์— ๋Œ€ํ•ด valid ๊ฒ€์‚ฌ๊ฐ€ ์ด๋ฃจ์–ด์ง€์ง€ ์•Š์•„ 500 ์—๋Ÿฌ ๋ฐœ์ƒ ๊ฐ€๋Šฅํ–ˆ์Šต๋‹ˆ๋‹ค. @Valid ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

@Kimhan-nah Kimhan-nah added the bug Something isn't working label Apr 8, 2024
@Kimhan-nah Kimhan-nah requested a review from wken5577 April 8, 2024 13:03
@Kimhan-nah Kimhan-nah self-assigned this Apr 8, 2024
@Kimhan-nah Kimhan-nah changed the title ๐Ÿ› [Fix] ๊ณต๊ณ  ์ „์ฒด ์กฐํšŒ ์ž˜๋ชป๋œ ์‘๋‹ต ์ˆ˜์ • ๐Ÿ› [Fix] ๊ณต๊ณ  ์ „์ฒด ์กฐํšŒ API์˜ ์ž˜๋ชป๋œ ์‘๋‹ต ์ˆ˜์ • Apr 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 75.82%. Comparing base (d4e5e32) to head (73f0200).

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #817      +/-   ##
============================================
- Coverage     75.92%   75.82%   -0.10%     
+ Complexity     1092     1090       -2     
============================================
  Files           366      366              
  Lines          4805     4806       +1     
  Branches        391      391              
============================================
- Hits           3648     3644       -4     
- Misses          989      993       +4     
- Partials        168      169       +1     
Flag Coverage ฮ”
integrationTest 69.93% <100.00%> (-0.12%) โฌ‡๏ธ
unitTest 36.82% <0.00%> (-0.01%) โฌ‡๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Kimhan-nah Kimhan-nah merged commit ccbaae4 into dev Apr 8, 2024
2 checks passed
@Kimhan-nah Kimhan-nah deleted the hotfix/recruitments branch April 8, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants