Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimhan-nah
force-pushed
the
563-feature-면접-날짜-등록-api
branch
from
4fccfed to
1e55eb8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## recruit-dev #805 +/- ##
=================================================
- Coverage 75.12% 75.11% -0.01%
- Complexity 1076 1082 +6
=================================================
Files 365 366 +1
Lines 4787 4803 +16
Branches 393 397 +4
=================================================
+ Hits 3596 3608 +12
- Misses 1011 1014 +3
- Partials 180 181 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wken5577
reviewed
Apr 3, 2024
| @@ -101,9 +106,12 @@ private void addCheckList(Question question, List<String> checkList) { | |||
| */ | |||
| @Transactional | |||
| public void updateFinalApplicationStatusAndNotification(UpdateApplicationStatusDto dto) { | |||
There was a problem hiding this comment.
저희 service layer parameter받는거 param으로 객체명 통일하기로 한거 아닌가여
There was a problem hiding this comment.
service/param/*Param.java 말씀하시는 거죠?
이부분 현재 service/dto/*Dto.java로 구성되어 있어서 지금 수정하면 승철님 PR이랑 컨플릭트 많이 생길 것 같습니다
마지막에 합치는 PR에서 한꺼번에 수정하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
updateFinalApplicationStatusAndNotification메서드)에서BusinessException->NotExistException가 더 적합한 것 같아서 수정했습니다.💡Issue 번호