Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] 최종결과 등록 #799

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Conversation

middlefitting
Copy link
Member

@middlefitting middlefitting commented Apr 1, 2024

📌 개요

  • 최종 결과 등록 api 입니다

💻 작업사항

  • 최종 결과 등록 기능 작성 및 단위 테스트 추가
  • 알림 기능은 멀티 모듈 사이클 이슈로 추후 구현
  • gradle 의존성 오류 수정
  • webMvcTest용 컨텍스트 구성

💡Issue 번호

@middlefitting middlefitting added the enhancement New feature or request label Apr 1, 2024
@middlefitting middlefitting self-assigned this Apr 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.03%. Comparing base (18ba598) to head (a834cf2).
Report is 1 commits behind head on recruit-dev.

Files Patch % Lines
.../java/gg/data/recruit/application/Application.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             recruit-dev     #799      +/-   ##
=================================================
- Coverage          75.08%   75.03%   -0.05%     
  Complexity          1078     1078              
=================================================
  Files                365      365              
  Lines               4792     4795       +3     
  Branches             396      396              
=================================================
  Hits                3598     3598              
- Misses              1013     1020       +7     
+ Partials             181      177       -4     
Flag Coverage Δ
integrationTest 69.59% <57.14%> (-0.07%) ⬇️
unitTest 32.36% <57.14%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controller, repository 테스트까지.. 꼼꼼하게 짜주셨군요..👍 코멘트 확인 부탁드립니당

@middlefitting middlefitting requested a review from Kimhan-nah April 1, 2024 11:16
@middlefitting middlefitting merged commit 40bc92d into recruit-dev Apr 1, 2024
2 checks passed
@middlefitting middlefitting deleted the fix-최종결과등록 branch April 1, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants