Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”¨ [Refactoring + Feature] νŒ¨λ„ν‹° 확인 API μž‘μ„± 및 νŒ¨λ„ν‹° μ •μ±… μˆ˜μ • #790 #791

Merged
merged 10 commits into from
Mar 30, 2024
Merged

πŸ”¨ [Refactoring + Feature] νŒ¨λ„ν‹° 확인 API μž‘μ„± 및 νŒ¨λ„ν‹° μ •μ±… μˆ˜μ • #790 #791

merged 10 commits into from
Mar 30, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 29, 2024 •
edited
Loading

πŸ“Œ κ°œμš”

  • μ˜€νƒ€ μˆ˜μ •
  • μ˜λ„μ™€ κ°™κ²Œ μž‘λ™ν•˜μ§€ μ•ŠλŠ” 둜직 μˆ˜μ •
  • νŒ¨λ„ν‹° ν™•μΈν•˜λŠ” API μž‘μ„±

πŸ’» μž‘μ—…μ‚¬ν•­

  • λ…Έμ‡Όμ‹ κ³  2~4μΈλ°©μ—μ„œ 2μΈμ‹œμž‘μ‹œ νŒ¨λ„ν‹°μ²˜λ¦¬κ°€ μ•ˆλ˜λŠ” 둜직문제 μˆ˜μ •
  • νŒ¨λ„ν‹° 정책이 μ•…μš©λ  여지가 λ†’λ‹€κ³  μƒκ°λ˜μ–΄, λ°© 5 λŒ“κΈ€ 3으둜 μˆ˜μ •
  • μ˜€νƒ€ μˆ˜μ •(AlredayReportedException -> AlreadyReportedException둜)
  • Category μ‘°νšŒν•  λ•Œ μƒκΈ°λŠ” OnPenalty μˆ˜μ •(ν”„λ‘ νŠΈμ—μ„œ 첫 ν™”λ©΄λΆ€ν„° μ‘°νšŒν•˜λ©΄ Notiλ„μš°κΈ°λ‘œ 함)
  • ν”„λ‘ νŠΈμ˜ μš”μ²­μœΌλ‘œ νŒ¨λ„ν‹° μ‘°νšŒν•˜λŠ” API μž‘μ„±(Noti λ„μš°κΈ° μœ„ν•¨)
  • EnumTypeμ—μ„œ μ‚¬μš©ν•˜μ§€ μ•ŠλŠ” ν•¨μˆ˜ μ‚­μ œ

πŸ’‘Issue 번호

@AreSain AreSain added bug Something isn't working enhancement New feature or request refactoring labels Mar 29, 2024
@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 29, 2024 13:19
@AreSain AreSain self-assigned this Mar 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 75.06%. Comparing base (6613d12) to head (8e63047).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev     #791      +/-   ##
============================================
+ Coverage     74.96%   75.06%   +0.09%     
+ Complexity     1074     1073       -1     
============================================
  Files           363      363              
  Lines          4770     4764       -6     
  Branches        396      393       -3     
============================================
  Hits           3576     3576              
+ Misses         1016     1012       -4     
+ Partials        178      176       -2
Flag Coverage Ξ”
integrationTest 69.58% <ΓΈ> (+0.06%) ⬆️
unitTest 32.24% <ΓΈ> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

JaBeast
JaBeast previously approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@AreSain AreSain requested a review from JaBeast March 30, 2024 11:14
@AreSain AreSain merged commit 6c42a3d into dev Mar 30, 2024
2 checks passed
@AreSain AreSain deleted the 790-refactoring-party-report branch March 30, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaBeast JaBeast JaBeast approved these changes

@ghyen ghyen ghyen approved these changes

@yes-ee yes-ee Awaiting requested review from yes-ee

Assignees

@AreSain AreSain

Labels
bug Something isn't working enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
4 participants
@AreSain @codecov-commenter @ghyen @JaBeast