Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”จ [Refactoring] 6๊ธฐ Party ์„œ๋น„์Šค ์ „์ฒด ๋ฆฌํŒฉํ† ๋ง #782

Merged
merged 15 commits into from
Mar 28, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 28, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • ๋ถ€์กฑํ•˜๋‹ค๊ณ  ์ƒ๊ฐ๋˜๋Š” ๋ถ€๋ถ„๋“ค์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • ์กฐํšŒ๋งŒ ํ•˜๋Š” API์— ReadOnly ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
  • Penalty ๋ถ€๋ถ„ staticํ•˜๊ฒŒ ๋ฐ”๊พธ์–ด์„œ ์—”ํ‹ฐํ‹ฐ ๋‚ด๋ถ€์—์„œ ํ™•์ธํ•˜๊ฒŒ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • slack bot service ๋‘๊ฐ€์ง€์— null ์˜ˆ์™ธ์ฒ˜๋ฆฌ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ฐฉ์žฅ์ด๊ถŒ์—์„œ nullํฌ์ธํ„ฐ ์ฐธ์กฐํ•˜๋˜ ๋ฒ„๊ทธ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • db์— ์ตœ๋Œ€ํ•œ ์ ‘๊ทผํ•˜์ง€ ์•Š๊ฒŒ ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • Hidden ๋œ comment๋ฅผ ์‚ฌ์šฉ์ž๊ฐ€ ๋ณผ ์ˆ˜ ์žˆ๋˜ ๋ฒ„๊ทธ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@AreSain AreSain added bug Something isn't working refactoring labels Mar 28, 2024
@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 28, 2024 06:15
@AreSain AreSain self-assigned this Mar 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.96%. Comparing base (307954e) to head (1f3ceef).
Report is 19 commits behind head on dev.

Files Patch % Lines
...pi/user/noti/service/sns/SlackPartybotService.java 0.00% 3 Missing โš ๏ธ
...ong/api/user/noti/service/sns/SlackbotService.java 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #782      +/-   ##
============================================
+ Coverage     73.39%   74.96%   +1.57%     
- Complexity     1050     1074      +24     
============================================
  Files           363      363              
  Lines          4770     4770              
  Branches        394      396       +2     
============================================
+ Hits           3501     3576      +75     
+ Misses         1095     1017      -78     
- Partials        174      177       +3     
Flag Coverage ฮ”
integrationTest 69.51% <37.50%> (+1.59%) โฌ†๏ธ
unitTest 32.20% <0.00%> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

JaBeast
JaBeast previously approved these changes Mar 28, 2024
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@AreSain AreSain merged commit 4094d62 into dev Mar 28, 2024
2 checks passed
@AreSain AreSain deleted the 778-refactoring-party-service branch March 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring
Projects
None yet
4 participants