Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› [Bug] ์นดํ…Œ๊ณ ๋ฆฌ๊ฐ€ ID์ˆœ์ด ์•„๋‹Œ ์ด๋ฆ„์ˆœ์œผ๋กœ ์ •๋ ฌ๋˜๋Š” ๋ฒ„๊ทธ ์ˆ˜์ • #776

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 26, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • ์นดํ…Œ๊ณ ๋ฆฌ๊ฐ€ ID์ˆœ์œผ๋กœ ์ •๋ ฌ๋˜์–ด์ง€์ง€ ์•Š์•„ ๊ธฐํƒ€๊ฐ€ ์ œ์ผ ๋จผ์ € ์˜ค๋Š” ๋ฒ„๊ทธ๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • ์นดํ…Œ๊ณ ๋ฆฌ๊ฐ€ ID์ˆœ์ด ์•„๋‹Œ ์ด๋ฆ„์ˆœ์œผ๋กœ ์ •๋ ฌ๋˜๋Š” ๋ฒ„๊ทธ ์ˆ˜์ •

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@AreSain AreSain added the bug Something isn't working label Mar 26, 2024
@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 26, 2024 10:22
@AreSain AreSain self-assigned this Mar 26, 2024
yes-ee
yes-ee previously approved these changes Mar 26, 2024
Copy link
Contributor

@yes-ee yes-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ!

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 74.87%. Comparing base (307954e) to head (650f511).
Report is 13 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #776      +/-   ##
============================================
+ Coverage     73.39%   74.87%   +1.48%     
- Complexity     1050     1071      +21     
============================================
  Files           363      363              
  Lines          4770     4769       -1     
  Branches        394      394              
============================================
+ Hits           3501     3571      +70     
+ Misses         1095     1018      -77     
- Partials        174      180       +6     
Flag Coverage ฮ”
integrationTest 69.42% <รธ> (+1.50%) โฌ†๏ธ
unitTest 32.20% <รธ> (+<0.01%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

JaBeast
JaBeast previously approved these changes Mar 26, 2024
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@AreSain AreSain merged commit b72317a into dev Mar 27, 2024
2 checks passed
@AreSain AreSain deleted the 773-bug-party-๋ฒ„๊ทธ branch March 27, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants