Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 [Test] Admin 카테고리 추가 및 제거 테스트 코드 작성 #760

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 24, 2024

📌 개요

  • admin 유저가 카테고리를 추가하거나 제거하는 로직을 작성했습니다.

💻 작업사항

  • 기존 서비스 로직에서 고정값으로 받던 defaultCategory를 name으로 검색("etc")으로 수정했습니다.(사유 : 처음 카테고리 생성시 defalut를 만들지 않으면 db에 접근해야함)
  • 카테고리를 제거할때, defaultCategory로 바뀌는지 확인하는 로직도 추가했습니다.
  • 400으로 오지 않는 exception을 수정했습니다.
  • 400으로 오던 duplicate exception을 수정했습니다.
  • 머지를 대비해 컨플릭트를 줄이기 위해 testUtills만 따로 수정

💡Issue 번호

@AreSain AreSain added the test label Mar 24, 2024
@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 24, 2024 09:33
@AreSain AreSain self-assigned this Mar 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.53%. Comparing base (307954e) to head (070e37c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #760      +/-   ##
============================================
+ Coverage     73.39%   73.53%   +0.14%     
- Complexity     1050     1053       +3     
============================================
  Files           363      363              
  Lines          4770     4769       -1     
  Branches        394      394              
============================================
+ Hits           3501     3507       +6     
+ Misses         1095     1088       -7     
  Partials        174      174              
Flag Coverage Δ
integrationTest 68.06% <100.00%> (+0.14%) ⬆️
unitTest 32.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AreSain AreSain changed the title 🧪 [Test] admin 카테고리 추가 및 제거 테스트 코드 작성 🧪 [Test] Admin 카테고리 추가 및 제거 테스트 코드 작성 Mar 24, 2024
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AreSain AreSain merged commit 9fe55a7 into dev Mar 25, 2024
2 checks passed
@AreSain AreSain deleted the 759-test-admin-카테고리-추가-제거 branch March 25, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧪 [Test] Admin 카테고리 추가 및 제거 테스트 코드 작성
4 participants