Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ§ͺ [Test] Admin ν…œν”Œλ¦Ώ μΆ”κ°€, 제거, μˆ˜μ • ν…ŒμŠ€νŠΈμ½”λ“œ μž‘μ„± #756

Merged
merged 6 commits into from
Mar 25, 2024
Merged

πŸ§ͺ [Test] Admin ν…œν”Œλ¦Ώ μΆ”κ°€, 제거, μˆ˜μ • ν…ŒμŠ€νŠΈμ½”λ“œ μž‘μ„± #756

merged 6 commits into from
Mar 25, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 23, 2024

πŸ“Œ κ°œμš”

  • Admin ν…œν”Œλ¦Ώ μΆ”κ°€, 제거, μˆ˜μ •μ— λŒ€ν•œ ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό μž‘μ„±ν–ˆμŠ΅λ‹ˆλ‹€.
  • Admin User인지 ν™•μΈν•˜λŠ” λ‘œμ§μ€ μΆ”κ°€ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.
  • @Valid μ˜΅μ…˜μ΄ ν™•μΈν•˜λŠ” λ‘œμ§μ€ μΆ”κ°€ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

πŸ’» μž‘μ—…μ‚¬ν•­

  • @Valid μ˜΅μ…˜ μΆ”κ°€ 및 message λ‹¬μ•„μ„œ μ—λŸ¬μ½”λ“œ νŒλ…μ„ μ‰½κ²Œ λ°”κΎΈμ—ˆμŠ΅λ‹ˆλ‹€.
  • ν…œν”Œλ¦Ώ μΆ”κ°€, 제거, μˆ˜μ •μ— λŒ€ν•œ ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό μž‘μ„±ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ’‘Issue 번호

@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 23, 2024 09:01
@AreSain AreSain self-assigned this Mar 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 73.77%. Comparing base (e9225ee) to head (5957c5c).
Report is 36 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev     #756      +/-   ##
============================================
- Coverage     74.16%   73.77%   -0.40%     
- Complexity      737     1031     +294     
============================================
  Files           166      351     +185     
  Lines          3178     4682    +1504     
  Branches        340      394      +54     
============================================
+ Hits           2357     3454    +1097     
- Misses          677     1054     +377     
- Partials        144      174      +30
Flag Coverage Ξ”
integrationTest 68.21% <ΓΈ> (-0.07%) ⬇️
unitTest 32.76% <ΓΈ> (+3.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@AreSain AreSain added the test label Mar 23, 2024
@AreSain AreSain changed the title [Test] Admin ν…œν”Œλ¦Ώ μΆ”κ°€, 제거, μˆ˜μ • ν…ŒμŠ€νŠΈμ½”λ“œ μž‘μ„± πŸ§ͺ [Test] Admin ν…œν”Œλ¦Ώ μΆ”κ°€, 제거, μˆ˜μ • ν…ŒμŠ€νŠΈμ½”λ“œ μž‘μ„± Mar 23, 2024
ghyen
ghyen approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AreSain AreSain merged commit f07723d into dev Mar 25, 2024
2 checks passed
@AreSain AreSain deleted the 755-test-admin-ν…œν”Œλ¦Ώ-μΆ”κ°€-제거-μˆ˜μ • branch March 25, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaBeast JaBeast JaBeast approved these changes

@ghyen ghyen ghyen approved these changes

@yes-ee yes-ee Awaiting requested review from yes-ee

Assignees

@AreSain AreSain

Labels
test
Projects
None yet
Milestone
No milestone
4 participants
@AreSain @codecov-commenter @ghyen @JaBeast