Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] 댓글 테스트 코드 추가 #743

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

JaBeast
Copy link
Contributor

@JaBeast JaBeast commented Mar 19, 2024

📌 개요

  • 댓글 생성api 테스트 코드 추가

💻 작업사항

  • 댓글 테스트 코드 추가(CommentControllerTest)
  • RoomNotOpenException을 BusinessException으로 extend (잘못된 에러코드 나오는거 수정)
  • TestDataUtils에 필요 코드 추가 (feat.승수님)
  • CommentService에 신고 유저 댓글 생성 막는 코드 추가

💡Issue 번호

@JaBeast JaBeast added the enhancement New feature or request label Mar 19, 2024
@JaBeast JaBeast requested review from ghyen, yes-ee and AreSain March 19, 2024 08:29
@JaBeast JaBeast self-assigned this Mar 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.25%. Comparing base (e9225ee) to head (59921c2).
Report is 34 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #743      +/-   ##
============================================
- Coverage     74.16%   73.25%   -0.91%     
- Complexity      737     1027     +290     
============================================
  Files           166      351     +185     
  Lines          3178     4682    +1504     
  Branches        340      394      +54     
============================================
+ Hits           2357     3430    +1073     
- Misses          677     1076     +399     
- Partials        144      176      +32     
Flag Coverage Δ
integrationTest 67.70% <ø> (-0.58%) ⬇️
unitTest 32.76% <ø> (+3.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AreSain
AreSain previously approved these changes Mar 19, 2024
Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@JaBeast JaBeast merged commit 53d2a0d into dev Mar 20, 2024
2 checks passed
@JaBeast JaBeast deleted the 740-test-comment테스트코드-작성 branch March 25, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] 6기 comment 테스트 코드 추가
4 participants