Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] 탬플릿 수정 API #715

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

JaBeast
Copy link
Contributor

@JaBeast JaBeast commented Mar 10, 2024

📌 개요

  • 탬플릿 수정 api

💻 작업사항

  • 템플릿 Admin Controller 코드 추가
  • 템플릿 Admin TemplateUpdateDto 추가
  • 템플릿 Admin Service 코드 추가
  • GameTemplate 엔티티 코드 추가

💡Issue 번호

@JaBeast JaBeast added the enhancement New feature or request label Mar 10, 2024
@JaBeast JaBeast requested review from ghyen, yes-ee and AreSain March 10, 2024 07:45
@JaBeast JaBeast self-assigned this Mar 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 72.98%. Comparing base (e9225ee) to head (ac0ef6f).
Report is 23 commits behind head on dev.

Files Patch % Lines
...data/src/main/java/gg/data/party/GameTemplate.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #715      +/-   ##
============================================
- Coverage     74.16%   72.98%   -1.19%     
- Complexity      737      995     +258     
============================================
  Files           166      339     +173     
  Lines          3178     4567    +1389     
  Branches        340      390      +50     
============================================
+ Hits           2357     3333     +976     
- Misses          677     1060     +383     
- Partials        144      174      +30     
Flag Coverage Δ
integrationTest 67.39% <0.00%> (-0.89%) ⬇️
unitTest 33.12% <0.00%> (+3.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaBeast JaBeast requested a review from AreSain March 11, 2024 03:30
Copy link
Contributor

@AreSain AreSain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. entity가 dto를 import할 수 없을줄은 저도 몰랐네요 ㅜ

@JaBeast JaBeast merged commit 377dab9 into dev Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Admin 템플릿 수정 API
4 participants