Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] admin 방 전체 조회 api pagination기능 추가 #699

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 7, 2024

📌 개요

  • pagination기능 추가

💻 작업사항

  • admin에서 방 전체 조회에 pagenation 기능 추가 및 dto 수정

💡Issue 번호

@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 7, 2024 09:29
@AreSain AreSain self-assigned this Mar 7, 2024
@AreSain AreSain changed the title ✨ [Feature] admin 방 전체 조회 api pagenation 기능 추가 ✨ [Feature] admin 방 전체 조회 api pagination기능 추가 Mar 7, 2024
JaBeast
JaBeast previously approved these changes Mar 7, 2024
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (e9225ee) to head (1c3ee60).
Report is 17 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #699      +/-   ##
============================================
- Coverage     74.16%   74.06%   -0.10%     
+ Complexity      737      730       -7     
============================================
  Files           166      164       -2     
  Lines          3178     3162      -16     
  Branches        340      337       -3     
============================================
- Hits           2357     2342      -15     
  Misses          677      677              
+ Partials        144      143       -1     
Flag Coverage Δ
integrationTest 68.15% <ø> (-0.13%) ⬇️
unitTest 29.34% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AreSain AreSain merged commit c274e24 into dev Mar 8, 2024
2 checks passed
@AreSain AreSain deleted the 698-admin-방-전체-조회-page branch March 8, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Admin 방 전체 조회 page 추가
5 participants