Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] Admin 게시글 전체 조회 API #694

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 7, 2024

📌 개요

  • 어드민이 게시글을 전체 조회하는 API

💻 작업사항

  • 게시글 작성자 intraid를 같이 response로 보낼 수 있게 작성
  • 기존 게시글 전체 조회에 creator user id response dto에서 제거

💡Issue 번호

@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 7, 2024 06:12
@AreSain AreSain self-assigned this Mar 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (e9225ee) to head (7ac726f).
Report is 10 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #694      +/-   ##
============================================
- Coverage     74.16%   74.06%   -0.10%     
+ Complexity      737      730       -7     
============================================
  Files           166      164       -2     
  Lines          3178     3162      -16     
  Branches        340      337       -3     
============================================
- Hits           2357     2342      -15     
  Misses          677      677              
+ Partials        144      143       -1     
Flag Coverage Δ
integrationTest 68.24% <ø> (-0.04%) ⬇️
unitTest 29.34% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JaBeast
JaBeast previously approved these changes Mar 7, 2024
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조회 코드 모두 통일성 있고 굿~

Copy link
Contributor

@yes-ee yes-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AreSain AreSain requested a review from JaBeast March 7, 2024 06:59
Copy link
Contributor

@JaBeast JaBeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@AreSain AreSain merged commit 060f267 into dev Mar 7, 2024
2 checks passed
@AreSain AreSain deleted the 692-Feature-admin-게시글-전체-조회 branch March 7, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Admin 게시글 전체 조회 API
4 participants