Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] startRoom API without 복면가왕 logic #687

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Conversation

ghyen
Copy link
Contributor

@ghyen ghyen commented Mar 6, 2024

📌 개요

  • 방 시작하는 api입니다. 시작 이후 복면가왕 즉, 익명 삭제 관련 로직은 추후 논의가 필요한 로직이니 해당 로직 제외한 버전입니다.

💻 작업사항

  • 방 나가기 API의 JAVA 명세 수정했습니다

✅ 변경로직

💡Issue 번호

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (e9225ee) to head (87a6a58).
Report is 7 commits behind head on dev.

❗ Current head 87a6a58 differs from pull request most recent head 77af97a. Consider uploading reports for the commit 77af97a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #687      +/-   ##
============================================
- Coverage     74.16%   74.06%   -0.10%     
+ Complexity      737      730       -7     
============================================
  Files           166      164       -2     
  Lines          3178     3162      -16     
  Branches        340      337       -3     
============================================
- Hits           2357     2342      -15     
  Misses          677      677              
+ Partials        144      143       -1     
Flag Coverage Δ
integrationTest 68.18% <ø> (-0.10%) ⬇️
unitTest 29.34% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AreSain AreSain requested review from yes-ee, JaBeast and AreSain March 6, 2024 07:05
@ghyen ghyen added the enhancement New feature or request label Mar 6, 2024
@ghyen ghyen added this to the 6th Sprint3 milestone Mar 6, 2024
Copy link
Contributor

@yes-ee yes-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커멘트 확인 부탁드립니다!

@AreSain AreSain self-requested a review March 6, 2024 08:41
@yes-ee yes-ee self-requested a review March 6, 2024 09:09
Copy link
Contributor

@yes-ee yes-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다...

@ghyen ghyen merged commit 7835d12 into dev Mar 6, 2024
2 checks passed
@ghyen ghyen deleted the 641-방-시작-API branch March 6, 2024 09:45
@ghyen ghyen changed the title [FIX] startRoom API without 복면가왕 logic [FEAT] startRoom API without 복면가왕 logic Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] 방 시작 API
4 participants