Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 방 상세 조회 api #671

Merged
merged 20 commits into from
Mar 4, 2024
Merged

Conversation

AreSain
Copy link
Contributor

@AreSain AreSain commented Mar 4, 2024

📌 개요

  • 방 상세 조회하는 API 작성

💻 작업사항

  • 방 상세조회하는 API 작성
  • Room Entity에 currentPeople 추가
  • CreateRoom 로직에 currentPeople 초기화 하는 생성자 수정

💡Issue 번호

@AreSain AreSain self-assigned this Mar 4, 2024
@AreSain AreSain added the enhancement New feature or request label Mar 4, 2024
@AreSain AreSain requested review from ghyen, yes-ee and JaBeast March 4, 2024 07:09
ghyen
ghyen previously approved these changes Mar 4, 2024
Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 예외 관련 코드 수정, comment Sevice에서 방이 open인지 확인하는 로직 수정 부탁드리겠습니다.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.00%. Comparing base (e9225ee) to head (c86894e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #671      +/-   ##
============================================
- Coverage     74.16%   74.00%   -0.16%     
+ Complexity      737      734       -3     
============================================
  Files           166      166              
  Lines          3178     3178              
  Branches        340      340              
============================================
- Hits           2357     2352       -5     
- Misses          677      680       +3     
- Partials        144      146       +2     
Flag Coverage Δ
integrationTest 68.21% <ø> (-0.07%) ⬇️
unitTest 29.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghyen ghyen self-requested a review March 4, 2024 07:29
ghyen
ghyen previously approved these changes Mar 4, 2024
Copy link
Contributor

@ghyen ghyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghyen ghyen self-requested a review March 4, 2024 07:46
Copy link
Contributor

@yes-ee yes-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 에러 코드 형식만 따로 맞추면 좋을 것 같습니다 수고하셨어요

@AreSain AreSain merged commit 8609662 into dev Mar 4, 2024
2 checks passed
@AreSain AreSain deleted the 638-feature-방-상세-조회-API branch March 4, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] 방 상세 조회 API
4 participants