-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] 방 상세 조회 api #671
The head ref may contain hidden characters: "638-feature-\uBC29-\uC0C1\uC138-\uC870\uD68C-API"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 예외 관련 코드 수정, comment Sevice에서 방이 open인지 확인하는 로직 수정 부탁드리겠습니다.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #671 +/- ##
============================================
- Coverage 74.16% 74.00% -0.16%
+ Complexity 737 734 -3
============================================
Files 166 166
Lines 3178 3178
Branches 340 340
============================================
- Hits 2357 2352 -5
- Misses 677 680 +3
- Partials 144 146 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 에러 코드 형식만 따로 맞추면 좋을 것 같습니다 수고하셨어요
📌 개요
💻 작업사항
💡Issue 번호