Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’š [Merge] λ¦¬ν—ˆμ„€ ν† λ„ˆλ¨ΌνŠΈλ₯Ό μœ„ν•œ merge #490

Merged
merged 5 commits into from
Jan 7, 2024

Conversation

Kimhan-nah
Copy link
Member

πŸ“Œ κ°œμš”

  • λ¦¬ν—ˆμ„€ ν† λ„ˆλ¨ΌνŠΈμ— 랜덀맀칭 μ μš©ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.

@Kimhan-nah Kimhan-nah added the enhancement New feature or request label Jan 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (673d8b4) 69.57% compared to head (8962f7d) 69.73%.
Report is 2 commits behind head on main.

Files Patch % Lines
.../gg/server/domain/rank/redis/RankRedisService.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #490      +/-   ##
============================================
+ Coverage     69.57%   69.73%   +0.16%     
- Complexity      824      826       +2     
============================================
  Files           255      255              
  Lines          3783     3810      +27     
  Branches        352      357       +5     
============================================
+ Hits           2632     2657      +25     
- Misses          949      951       +2     
  Partials        202      202              
Flag Coverage Ξ”
integrationTest 69.44% <95.23%> (+0.16%) ⬆️
unitTest 10.26% <2.38%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν•˜μ˜€μŠ΅λ‹ˆλ‹€!

Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€!

@Kimhan-nah Kimhan-nah merged commit 958861a into main Jan 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants