Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] #478 path variable add #479

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[FIX] #478 path variable add #479

merged 1 commit into from
Jan 9, 2024

Conversation

AYoungSn
Copy link
Contributor

@AYoungSn AYoungSn commented Jan 3, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • path variable annotation ๋น ์ง„ ๋ถ€๋ถ„ ์ˆ˜์ •

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • annotation ์ถ”๊ฐ€

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@AYoungSn AYoungSn requested a review from middlefitting January 3, 2024 10:37
@AYoungSn AYoungSn self-assigned this Jan 3, 2024
@AYoungSn AYoungSn added the bug Something isn't working label Jan 3, 2024
@AYoungSn AYoungSn requested a review from Kimhan-nah January 3, 2024 10:38
SONGS4RI
SONGS4RI approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ•˜์˜€์Šต๋‹ˆ๋‹ค!

Kimhan-nah
Kimhan-nah approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ท!

@AYoungSn AYoungSn merged commit 4b6da95 into dev Jan 9, 2024
1 check passed
@AYoungSn AYoungSn deleted the 478-bug-pingpongv2ranksgametype-path-variable-์ถ”๊ฐ€ branch January 9, 2024 11:12
Newsujin pushed a commit that referenced this pull request Feb 3, 2024
@AYoungSn
[FIX] #478 path variable add (#479)
b071f16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SONGS4RI SONGS4RI SONGS4RI approved these changes

@Kimhan-nah Kimhan-nah Kimhan-nah approved these changes

@middlefitting middlefitting Awaiting requested review from middlefitting

Assignees

@AYoungSn AYoungSn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๐Ÿ›ย [Bug] /pingpong/v2/ranks/{gameType} path variable ์ถ”๊ฐ€
3 participants
@AYoungSn @Kimhan-nah @SONGS4RI