Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Fix] 토너먼트 LIVE 상태에서도 신청 삭제 되는 이슈 #456

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

SONGS4RI
Copy link
Contributor

📌 개요

  • 토너먼트 LIVE 상태에서도 신청 삭제 되는 이슈 해결

💻 작업사항

  • 토너먼트가 BEFORE 가 아니라면 TournamentUpdateException()

✅ 변경로직

💡Issue 번호

@SONGS4RI SONGS4RI self-assigned this Dec 22, 2023
@SONGS4RI SONGS4RI added the bug Something isn't working label Dec 22, 2023
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@codecov-commenter
Copy link

Codecov Report

Attention: 220 lines in your changes are missing coverage. Please review.

Comparison is base (76734b6) 68.77% compared to head (e879362) 10.01%.
Report is 28 commits behind head on dev.

Files Patch % Lines
...r/domain/match/service/MatchTournamentService.java 0.00% 90 Missing ⚠️
...min/tournament/service/TournamentAdminService.java 38.77% 29 Missing and 1 partial ⚠️
...r/domain/tournament/service/TournamentService.java 13.04% 19 Missing and 1 partial ⚠️
...m/gg/server/domain/match/service/MatchService.java 0.00% 15 Missing ⚠️
...com/gg/server/domain/game/service/GameService.java 0.00% 11 Missing ⚠️
...java/com/gg/server/domain/game/GameController.java 0.00% 9 Missing ⚠️
...server/domain/tournament/type/TournamentRound.java 46.66% 8 Missing ⚠️
...om/gg/server/domain/match/utils/SlotGenerator.java 0.00% 6 Missing ⚠️
...erver/domain/match/type/TournamentMatchStatus.java 0.00% 4 Missing ⚠️
.../java/com/gg/server/domain/noti/type/NotiType.java 0.00% 4 Missing ⚠️
... and 12 more
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #456       +/-   ##
=============================================
- Coverage     68.77%   10.01%   -58.76%     
+ Complexity      793       75      -718     
=============================================
  Files           252      255        +3     
  Lines          3654     3783      +129     
  Branches        339      352       +13     
=============================================
- Hits           2513      379     -2134     
- Misses          949     3395     +2446     
+ Partials        192        9      -183     
Flag Coverage Δ
integrationTest ?
unitTest 10.01% <19.70%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다!

Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니당

@SONGS4RI SONGS4RI merged commit 673d8b4 into dev Dec 22, 2023
1 check passed
@SONGS4RI SONGS4RI deleted the tournament-user-rigistration-refactor branch December 22, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] 토너먼트 진행중에 등록 취소 가능한 문제
5 participants