Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] 토너먼트 알림 추가하기 #431

Merged
merged 29 commits into from
Dec 22, 2023

Conversation

Newsujin
Copy link
Contributor

@Newsujin Newsujin commented Dec 20, 2023

📌 개요

  • 토너먼트 시작, 취소, 매칭 시 유저 알림 기능 추가

💻 작업사항

  • 토너먼트 취소 시 해당 토너먼트의 모든 참가자에게 알림 및 메일 전송
  • 토너먼트 게임 매칭 시 해당 게임 유저에게 알림 및 메일 전송
  • 관리자 토너먼트 결과 수정할 시 변경되는 winner, loser에게 알림 전송
  • Notinoti_type 컬럼이 VARCHAR(15) -> VARCHAR(30)으로 수정
    • TOURNAMET_GAME_MATCHED와 같은 값이 저장되어야 합니다.

✅ 변경로직

💡Issue 번호

@Newsujin Newsujin added the enhancement New feature or request label Dec 20, 2023
@Newsujin Newsujin self-assigned this Dec 20, 2023
@Newsujin Newsujin linked an issue Dec 20, 2023 that may be closed by this pull request
3 tasks
@Newsujin Newsujin force-pushed the 370-feature-토너먼트-알림-추가하기 branch from cbe6850 to b28e991 Compare December 21, 2023 04:39
@Newsujin Newsujin force-pushed the 370-feature-토너먼트-알림-추가하기 branch from 6abae1c to db612ac Compare December 21, 2023 05:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (76734b6) 68.77% compared to head (6c17656) 69.57%.
Report is 20 commits behind head on dev.

Files Patch % Lines
...min/tournament/service/TournamentAdminService.java 73.46% 8 Missing and 5 partials ⚠️
...com/gg/server/domain/game/service/GameService.java 18.18% 6 Missing and 3 partials ⚠️
...om/gg/server/domain/match/utils/SlotGenerator.java 0.00% 6 Missing ⚠️
...m/gg/server/domain/match/service/MatchService.java 66.66% 3 Missing and 2 partials ⚠️
...java/com/gg/server/domain/game/GameController.java 66.66% 2 Missing and 1 partial ⚠️
...r/domain/match/service/MatchTournamentService.java 96.66% 1 Missing and 2 partials ⚠️
...r/domain/tournament/service/TournamentService.java 78.57% 1 Missing and 2 partials ⚠️
...gg/server/admin/game/service/GameAdminService.java 50.00% 2 Missing ⚠️
...n/match/exception/LosingTeamNotFoundException.java 0.00% 2 Missing ⚠️
...r/domain/team/exception/TeamNotFoundException.java 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #431      +/-   ##
============================================
+ Coverage     68.77%   69.57%   +0.80%     
- Complexity      793      823      +30     
============================================
  Files           252      255       +3     
  Lines          3654     3777     +123     
  Branches        339      349      +10     
============================================
+ Hits           2513     2628     +115     
  Misses          949      949              
- Partials        192      200       +8     
Flag Coverage Δ
integrationTest 69.28% <80.30%> (+0.84%) ⬆️
unitTest 10.03% <19.31%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

middlefitting
middlefitting previously approved these changes Dec 21, 2023
Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 코드와 함께 잘 작성해 주신 것 같습니다. 늦게까지 고생 많으셨습니다!

Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 남겼습니닷

Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인완료 하였습니다!!

@Kimhan-nah Kimhan-nah merged commit 7f16ac0 into dev Dec 22, 2023
1 check passed
@Kimhan-nah Kimhan-nah deleted the 370-feature-토너먼트-알림-추가하기 branch December 22, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Noti 테이블의 noti_type 컬럼 길이 수정 ✨ [Feature] 토너먼트 알림 추가하기
5 participants