Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› [Fix] 메인 νŽ˜μ΄μ§€μ—μ„œ ν† λ„ˆλ¨ΌνŠΈ κ²Œμž„ μ·¨μ†Œ λ™μž‘ λ°©μ–΄ #430

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

SONGS4RI
Copy link
Contributor

πŸ“Œ κ°œμš”

  • 이미 맀칭이 작힌 ν† λ„ˆλ¨ΌνŠΈ κ²Œμž„μ— λŒ€ν•΄ μ·¨μ†Œν•œλ‹€λ©΄ 403 μ—λŸ¬λ₯Ό throw ν•˜λ„λ‘ μˆ˜μ •

πŸ’» μž‘μ—…μ‚¬ν•­

  • MatchService : λ°©μ–΄ 둜직 μΆ”κ°€
  • ErrorCode : μ—λŸ¬ μ½”λ“œ μΆ”κ°€
  • MatchServiceTest : ν…ŒμŠ€νŠΈ μΌ€μ΄μŠ€ μΆ”κ°€λ‘œ μΈν•œ ν…ŒμŠ€νŠΈ μ½”λ“œ μΆ”κ°€

βœ… λ³€κ²½λ‘œμ§

πŸ’‘Issue 번호

@SONGS4RI SONGS4RI added the bug Something isn't working label Dec 20, 2023
@SONGS4RI SONGS4RI self-assigned this Dec 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (76734b6) 68.77% compared to head (20abc19) 69.25%.
Report is 8 commits behind head on dev.

Files Patch % Lines
...min/tournament/service/TournamentAdminService.java 75.00% 8 Missing and 4 partials ⚠️
...com/gg/server/domain/game/service/GameService.java 16.66% 4 Missing and 1 partial ⚠️
...om/gg/server/domain/match/utils/SlotGenerator.java 0.00% 4 Missing ⚠️
...r/domain/match/service/MatchTournamentService.java 96.10% 1 Missing and 2 partials ⚠️
...r/domain/team/exception/TeamNotFoundException.java 0.00% 2 Missing ⚠️
...ent/exception/TournamentGameNotFoundException.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #430      +/-   ##
============================================
+ Coverage     68.77%   69.25%   +0.48%     
- Complexity      793      809      +16     
============================================
  Files           252      254       +2     
  Lines          3654     3731      +77     
  Branches        339      346       +7     
============================================
+ Hits           2513     2584      +71     
  Misses          949      949              
- Partials        192      198       +6     
Flag Coverage Ξ”
integrationTest 68.96% <85.50%> (+0.51%) ⬆️
unitTest 9.86% <25.50%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

@SONGS4RI SONGS4RI merged commit 1f587c0 into dev Dec 21, 2023
1 check passed
@SONGS4RI SONGS4RI deleted the tournament-game-cancel-in-main-page branch December 21, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants