Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”¨ [Refactor] ν† λ„ˆλ¨ΌνŠΈ 생성 및 μˆ˜μ • μ‹œκ°„ 검증 둜직 μˆ˜μ • #407

Merged
merged 4 commits into from
Dec 18, 2023
Merged

πŸ”¨ [Refactor] ν† λ„ˆλ¨ΌνŠΈ 생성 및 μˆ˜μ • μ‹œκ°„ 검증 둜직 μˆ˜μ • #407

merged 4 commits into from
Dec 18, 2023

Conversation

SONGS4RI
Copy link
Contributor

@SONGS4RI SONGS4RI commented Dec 18, 2023 •
edited
Loading

πŸ“Œ κ°œμš”

  • κΈ°μ‘΄ μ‹œκ°„λ‘œμ§ μˆ˜μ •
  • μ΅œμ†Œ 48μ‹œκ°„ 이후 생성 κ°€λŠ₯ ν•˜λ˜ λ‘œμ§μ„ ν˜„μž¬μΌ κΈ°μ€€ μ΄ν‹€λ’€λ‘œ μˆ˜μ •
  • interval μ‹œκ°„μœΌλ‘œ μ‹œμž‘μ‹œκ°„μ˜ 뢄이 λ‚˜λˆ„μ–΄ 떨어져야함 (15λΆ„, 30λΆ„, 45λΆ„, 00λΆ„)

πŸ’» μž‘μ—…μ‚¬ν•­

  • TournamentAdminService: checkValidTournamentTime λ§€μ„œλ“œ μˆ˜μ •
  • TournamentAdminControllerTest && TournamentAdminServiceTest: ν…ŒμŠ€νŠΈ μ½”λ“œ μˆ˜μ •
  • TestDataUtils: createSlot λ§€μ„œλ“œ μΆ”κ°€

βœ… λ³€κ²½λ‘œμ§

πŸ’‘Issue 번호

@SONGS4RI SONGS4RI self-assigned this Dec 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (78e59aa) 69.35% compared to head (099a3ab) 69.36%.

Files Patch % Lines
...min/tournament/service/TournamentAdminService.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                dev     #407   +/-   ##
=========================================
  Coverage     69.35%   69.36%           
  Complexity      812      812           
=========================================
  Files           254      254           
  Lines          3720     3724    +4     
  Branches        341      343    +2     
=========================================
+ Hits           2580     2583    +3     
+ Misses          946      945    -1     
- Partials        194      196    +2
Flag Coverage Ξ”
integrationTest 69.01% <50.00%> (-0.03%) ⬇️
unitTest 9.96% <83.33%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@SONGS4RI SONGS4RI force-pushed the refactor-tournament-time-condition branch from f9eb31a to 2f7b6fa Compare December 18, 2023 06:43
Kimhan-nah
Kimhan-nah approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹·

Newsujin
Newsujin approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!!

@SONGS4RI SONGS4RI merged commit 8f9f412 into dev Dec 18, 2023
1 check passed
@SONGS4RI SONGS4RI deleted the refactor-tournament-time-condition branch December 18, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Newsujin Newsujin Newsujin approved these changes

@Kimhan-nah Kimhan-nah Kimhan-nah approved these changes

@middlefitting middlefitting Awaiting requested review from middlefitting

@kokomong2 kokomong2 Awaiting requested review from kokomong2

Assignees

@SONGS4RI SONGS4RI

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

πŸ”¨ [Refactoring] ν† λ„ˆλ¨ΌνŠΈ μ‹œκ°„ 쑰건 μΆ”κ°€
4 participants
@SONGS4RI @codecov-commenter @Kimhan-nah @Newsujin