-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Feature] 토너먼트 게임 매칭 로직 추가 #404
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #404 +/- ##
============================================
+ Coverage 68.88% 69.35% +0.46%
- Complexity 786 812 +26
============================================
Files 250 254 +4
Lines 3648 3720 +72
Branches 339 341 +2
============================================
+ Hits 2513 2580 +67
- Misses 946 947 +1
- Partials 189 193 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/main/java/com/gg/server/admin/tournament/service/TournamentAdminService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gg/server/domain/match/type/TournamentMatchStatus.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gg/server/domain/team/exception/TeamIdNotMatchException.java
Show resolved
Hide resolved
src/main/java/com/gg/server/domain/tournament/service/TournamentService.java
Show resolved
Hide resolved
src/main/java/com/gg/server/domain/tournament/type/TournamentRound.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gg/server/global/scheduler/TournamentScheduler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인 부탁드려요!
src/main/java/com/gg/server/admin/tournament/service/TournamentAdminService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gg/server/domain/tournament/type/TournamentUserStatus.java
Show resolved
Hide resolved
src/main/java/com/gg/server/domain/match/service/MatchTournamentService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다.
src/main/java/com/gg/server/admin/tournament/service/TournamentAdminService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고많으셨습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다~ 수고하셨습니다!
game winnerTeam 명칭 winningTeam으로 수정
MatchTournamentService 추가
match util 함수와 update score 함수 호출 순서 수정
f7bac94
to
54a34b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상당히 많은 로직을 추가해주시느라 고생 많으셨습니다!! 감사합니다 :-)
📌 개요
관리자 토너먼트 수정 API
,토너먼트 게임 결과 등록 API
,토너먼트 매칭 스케줄러
에서 사용되는 로직입니다.💻 작업사항
MatchTournamentService
토너먼트 매칭 서비스의 메서드checkTournamentGame()
: 토너먼트 게임 매칭이 필요한지 확인하는 함수TournamentMatchStatus
enum 값을 반환합니다. (아래에 설명)matchGames()
: 토너먼트 게임 매칭 함수updateMatchedGameUser()
: 이미 매칭된 게임의 팀 유저를 수정하는 함수TournamentMatchStatus
Enum ClassIMPOSSIBLE
: 매칭 불가능POSSIBLE
: 매칭 가능ALREADY_MATCHED
: 이미 다음 경기가 매칭된 상태 (매칭 불가능)토너먼트 게임 시간에 대하여
SlotManagement
의interval
을 고려하여 계산하도록 수정 예정입니다.startTime
,endTime
모두 interval을 고려하여 앞뒤로 넉넉하게 block 시켜줍니다.기타 수정사항
TeamIdNotMatchException
에서 ErrorCode의.getMessage()
를 사용하도록 수정TournamentGameNotFoundException
에서 잘못 사용중이었던 ErrorCode 수정test/domain/match/service/MatchTestUtils.java
->test/utils/MatchTestUtils.java
로 이동TournamentRound
에int roundNum
필드가 추가되었습니다.마지막으로..
💡Issue 번호