✨ [Feature] 토너먼트 유저 참가 신청 API #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SONGS4RI
requested review from
Kimhan-nah,
middlefitting,
Newsujin and
kokomong2
Newsujin
reviewed
Dec 13, 2023
src/main/java/com/gg/server/domain/tournament/service/TournamentService.java
Show resolved
Hide resolved
src/main/java/com/gg/server/domain/tournament/service/TournamentService.java
Show resolved
Hide resolved
SONGS4RI
force-pushed
the
register-tournament-user
branch
from
7318047 to
46c640d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #383 +/- ##
============================================
+ Coverage 69.26% 69.33% +0.07%
- Complexity 787 795 +8
============================================
Files 251 251
Lines 3579 3594 +15
Branches 342 344 +2
============================================
+ Hits 2479 2492 +13
+ Misses 909 907 -2
- Partials 191 195 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
middlefitting
approved these changes
Dec 13, 2023
src/main/java/com/gg/server/admin/tournament/service/TournamentAdminService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
BEFORE일때만 신청 가능합니다. (아닐시 throw)💻 작업사항
TournamentAdminAddUserResponseDto: boolean -> Boolean 으로 변경TournamentAdminService: java docs 추가 및 코드 가독성 개선TournamentController&&TournamentService: 토너먼트 유저 참가 신청 매서드 추가TournamentUserRepository: findAllByUser 매서드 추가TournamentFindControllerTest&&TournamentServiceTest: 테스트 코드 추가✅ 변경로직
TournamentServiceTest: 잘못된 테스트 코드 삭제💡Issue 번호