Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”จ [Refactor] ํ† ๋„ˆ๋จผํŠธ ์ƒ์„ฑ ๋ฐ ์ˆ˜์ • ๋งค์„œ๋“œ ์ถ”๊ฐ€ ๋ฐ ์ˆ˜์ • #376

Merged
merged 3 commits into from
Dec 12, 2023
Merged

๐Ÿ”จ [Refactor] ํ† ๋„ˆ๋จผํŠธ ์ƒ์„ฑ ๋ฐ ์ˆ˜์ • ๋งค์„œ๋“œ ์ถ”๊ฐ€ ๋ฐ ์ˆ˜์ • #376

merged 3 commits into from
Dec 12, 2023

Conversation

SONGS4RI
Copy link
Contributor

๐Ÿ“Œ ๊ฐœ์š”

  1. ํ† ๋„ˆ๋จผํŠธ๋ฅผ ์ƒ์„ฑํ•˜๊ณ  ์ˆ˜์ •ํ•  ๋•Œ ํ•ด๋‹น ๊ธฐ๊ฐ„์— ๊ฒŒ์ž„์ด ์กด์žฌํ•˜๋Š”์ง€ ํ™•์ธํ•˜๋Š” ๋งค์„œ๋“œ ์ถ”๊ฐ€
  2. ๊ธฐ์กด ์œ ํšจ ์‹œ๊ฐ„์„ ๊ฒ€์ฆํ•˜๋Š” ๋กœ์ง์„ ์ฟผ๋ฆฌ๋ฌธ์œผ๋กœ ๋ณ€๊ฒฝ

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • TournamentAdminService
    • checkConflictedTournament : ๊ธฐ์กด ๋กœ์ง ์ฟผ๋ฆฌ๋ฌธ์œผ๋กœ ๋ณ€๊ฒฝ
    • createTournament && updateTournament : ๊ฒŒ์ž„ ์กด์žฌ ์—ฌ๋ถ€ ํ™•์ธ ๋งค์„œ๋“œ ์ถ”๊ฐ€
    • checkGameExistence: ์ฟผ๋ฆฌ๋ฌธ์„ ํ†ตํ•œ ๊ฒŒ์ž„ ์กด์žฌ ํ™•์ธ ๋งค์„œ๋“œ
  • GameRepository: ์ฟผ๋ฆฌ๋ฌธ ์ถ”๊ฐ€
  • TournamentRepository: ์ฟผ๋ฆฌ๋ฌธ ์ถ”๊ฐ€
  • TournamentAdminControllerTest && TournamentAdminServiceTest && TournamentServiceTest : ํ…Œ์ŠคํŠธ ์ฝ”๋“œ

โœ… ๋ณ€๊ฒฝ๋กœ์ง

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@SONGS4RI SONGS4RI added enhancement New feature or request refactoring labels Dec 12, 2023
@SONGS4RI SONGS4RI self-assigned this Dec 12, 2023
@SONGS4RI SONGS4RI requested a review from Newsujin December 12, 2023 06:38
Newsujin
Newsujin previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธ ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค!

middlefitting
middlefitting previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@SONGS4RI SONGS4RI dismissed stale reviews from middlefitting and Newsujin via 497b32f December 12, 2023 11:25
@SONGS4RI SONGS4RI force-pushed the refactor-tournament-create-update branch from 00c8b44 to 497b32f Compare December 12, 2023 11:25
Newsujin
Newsujin approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ท!

@SONGS4RI SONGS4RI merged commit c5b6545 into dev Dec 12, 2023
@SONGS4RI SONGS4RI deleted the refactor-tournament-create-update branch December 12, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Newsujin Newsujin Newsujin approved these changes

@Kimhan-nah Kimhan-nah Kimhan-nah approved these changes

@kokomong2 kokomong2 Awaiting requested review from kokomong2

@middlefitting middlefitting Awaiting requested review from middlefitting

Assignees

@SONGS4RI SONGS4RI

Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
4 participants
@SONGS4RI @Kimhan-nah @middlefitting @Newsujin