Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Feature] tournament 테이블 초기화 SQL 추가 #306

Merged
merged 3 commits into from
Nov 9, 2023
Merged

✨ [Feature] tournament 테이블 초기화 SQL 추가 #306

merged 3 commits into from
Nov 9, 2023

Conversation

Kimhan-nah
Copy link
Member

@Kimhan-nah Kimhan-nah commented Nov 9, 2023 •
edited
Loading

📌 개요

  • 토너먼트 테이블 초기화하는 v3 파일 추가

💻 작업사항

Tournament, TournamentGame Entity 수정

  • TournamentGame Entity에서 id @Column annotation 삭제 (컬럼명 잘못됨)
  • enum type을 사용하는 필드에 @Enumerated annotation 추가

tournament, tournament_game, tournament_user 테이블 초기화하는 sql v3 추가

  • tournamet_user의 is_joined 컬럼을 BIT(1) 대신 BOOLEAN으로 설정했습니다.
    MySQL 내부적으로 TINYINT(1)로 저장되며 이를 권장한다고 합니다.
    스크린샷 2023-11-09 오후 12 59 45

💡Issue 번호

@Kimhan-nah Kimhan-nah added enhancement New feature or request refactoring labels Nov 9, 2023
@Kimhan-nah Kimhan-nah self-assigned this Nov 9, 2023
@Kimhan-nah Kimhan-nah changed the title ✨ [Feature] Tournament V3 flyway sql 추가 ✨ [Feature] tournament 테이블 초기화 SQL 추가 Nov 9, 2023
middlefitting
middlefitting approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하게 잘 작성해주신것 같습니다. 고생하셨습니다!

kokomong2
kokomong2 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@kokomong2 kokomong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

데이터 관련해서 너무 잘 처리해주신것 같습니다.

src/main/java/com/gg/server/domain/tournament/data/Tournament.java Show resolved Hide resolved
src/main/resources/db/migration/V3__migration_42gg_5th.sql Show resolved Hide resolved
SONGS4RI
SONGS4RI approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

설명이 잘적혀있어서 금방 이해했습니다. 고생하셨어요!

Newsujin
Newsujin approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하게 수정해주셔서 감사합니다. 고생 하셨습니다!!

@Kimhan-nah Kimhan-nah merged commit 3767702 into dev Nov 9, 2023
@Kimhan-nah Kimhan-nah deleted the tournament-flyway branch November 9, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokomong2 kokomong2 kokomong2 approved these changes

@Newsujin Newsujin Newsujin approved these changes

@SONGS4RI SONGS4RI SONGS4RI approved these changes

@middlefitting middlefitting middlefitting approved these changes

Assignees

@Kimhan-nah Kimhan-nah

Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] 토너먼트 관련 테이블 flyway sql 생성
5 participants
@Kimhan-nah @middlefitting @SONGS4RI @Newsujin @kokomong2