Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Rename timeRecord to dailyLogtime #421

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[Chore] Rename timeRecord to dailyLogtime #421

merged 2 commits into from
Dec 7, 2023

Conversation

yoopark
Copy link
Contributor

@yoopark yoopark commented Dec 7, 2023

Summary

  • timeRecord 변수명이 어울리지 않는 것 같아 dailyLogtime으로 이름 변경하였습니다.
  • dailyLogtime이 0시간 0분일 때 접속 기록 없음으로 표시되도록 수정하였습니다.

Describe your changes

image

Issue number and link

@yoopark yoopark added the enhancement New feature or request label Dec 7, 2023
@yoopark yoopark self-assigned this Dec 7, 2023
42sungwook
42sungwook approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 제가 좀 더 신경썼어야되는데 디테일 감사합니다

@yoopark yoopark merged commit aa56796 into develop Dec 7, 2023
5 checks passed
@yoopark yoopark deleted the chore/rename-time-record-to-daily-logtime branch December 7, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42sungwook 42sungwook 42sungwook approved these changes

Assignees

@yoopark yoopark

Labels
enhancement New feature or request
Projects
42Stat
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoopark @42sungwook