Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 데이터가 없을 때에 대한 핸들링 (최근 쓴 코멘트, 인연 스코어) #334

Merged
merged 4 commits into from
Oct 20, 2023
Merged

[Fix] 데이터가 없을 때에 대한 핸들링 (최근 쓴 코멘트, 인연 스코어) #334

merged 4 commits into from
Oct 20, 2023

Conversation

yoopark
Copy link
Contributor

@yoopark yoopark commented Oct 18, 2023

Summary

최근 쓴 코멘트 없을 때
스크린샷 2023-10-18 오후 8 48 15

인연 스코어 없을 때
스크린샷 2023-10-18 오후 8 50 51

Describe your changes

TeamInfo 표는 적절한 UI가 잘 생각이 나지 않아 일단 보류합니다.

Issue number and link

@yoopark yoopark added the bug Something isn't working label Oct 18, 2023
@yoopark yoopark requested a review from 42sungwook October 18, 2023 11:53
@yoopark yoopark self-assigned this Oct 18, 2023
42sungwook
42sungwook requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teamInfo에 대한 레이블이 따로 없어서 그런 것 같은데
좌측 상단에 다른 카드들처럼 레이블을 추가하고 데이터가 없을 때
과제 기록이 없습니다 문구를 가운데 보여주는게 좋을 것 같아요

@yoopark
Copy link
Contributor Author

yoopark commented Oct 19, 2023

image

기발하십니다.

@yoopark yoopark merged commit 984dd03 into develop Oct 20, 2023
@yoopark yoopark deleted the fix/handle-text-when-data-is-none branch October 20, 2023 12:50
@42sungwook 42sungwook restored the fix/handle-text-when-data-is-none branch October 21, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42sungwook 42sungwook 42sungwook approved these changes

Assignees

@yoopark yoopark

Labels
bug Something isn't working
Projects
42Stat
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

데이터가 없을 때의 프론트 표현 방식 제안
2 participants
@yoopark @42sungwook