Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] ReLoginDialog body 텍스트 고정 #333

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[Fix] ReLoginDialog body 텍스트 고정 #333

merged 1 commit into from
Oct 19, 2023

Conversation

yoopark
Copy link
Contributor

@yoopark yoopark commented Oct 18, 2023

Summary

image

Describe your changes

  • 기존 안에서는 error.message가 그대로 노출되어 UX 상 좋지 않다는 피드백이 있었습니다.
  • 이후 Backend 400 반환 시 Code가 분기되면, 그에 상응하는 body text를 다시 변경할 예정입니다.

Issue number and link

@yoopark yoopark added the bug Something isn't working label Oct 18, 2023
@yoopark yoopark requested a review from 42sungwook October 18, 2023 11:26
@yoopark yoopark self-assigned this Oct 18, 2023
@yoopark yoopark changed the title fix(ReLoginDialog): body 텍스트 고정 [Fix](ReLoginDialog) body 텍스트 고정 Oct 18, 2023
@yoopark yoopark changed the title [Fix](ReLoginDialog) body 텍스트 고정 [Fix] ReLoginDialog body 텍스트 고정 Oct 18, 2023
42sungwook
42sungwook approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니당

@yoopark yoopark merged commit 85f4ee8 into develop Oct 19, 2023
8 checks passed
@yoopark yoopark deleted the fix/re-login-dialog-fixed-body-text branch October 19, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42sungwook 42sungwook 42sungwook approved these changes

Assignees

@yoopark yoopark

Labels
bug Something isn't working
Projects
42Stat
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

프론트 400 받았을 때, error message 대신 재로그인 필요로 변경
2 participants
@yoopark @42sungwook