Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] FAB 추가 #332

Merged
merged 2 commits into from
Oct 19, 2023
Merged

[Feat] FAB 추가 #332

merged 2 commits into from
Oct 19, 2023

Conversation

yoopark
Copy link
Contributor

@yoopark yoopark commented Oct 18, 2023

Summary

  • FAB를 추가하였습니다.
  • 평가로그 검색 버튼이 더 눈에 띄게 변경되었습니다.

Ref. https://mui.com/material-ui/react-floating-action-button/

Describe your changes

기존

image

변경

image

Extended FAB (예시)
image

Issue number and link

@yoopark yoopark added the enhancement New feature or request label Oct 18, 2023
@yoopark yoopark requested a review from 42sungwook October 18, 2023 11:15
@yoopark yoopark self-assigned this Oct 18, 2023
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

검색하기 문구는 사진상에는 표시되있는데 코드에는 없는 걸로 보여요
의도된건지만 확인해주세요!
확실히 크게 보이니까 더 좋네요👍

@yoopark
Copy link
Contributor Author

yoopark commented Oct 19, 2023

검색하기 문구는 사진상에는 표시되있는데 코드에는 없는 걸로 보여요

의도된건지만 확인해주세요!

확실히 크게 보이니까 더 좋네요👍

넵 의도하긴 했습니다! 강조되지 않은 느낌이 여전하다면 Desktop만 Extended FAB로 수정할 여지도 있습니다.

@42sungwook
Copy link
Contributor

42sungwook commented Oct 19, 2023

저는 데스크탑에서는 문구까지 보여주는게 더 좋은 것 같아요.
근데 과하다 생각하시면 지금도 충분히 좋습니다!

@yoopark
Copy link
Contributor Author

yoopark commented Oct 19, 2023

저는 데스크탑에서는 문구까지 보여주는게 더 좋은 것 같아요. 근데 과하다 생각하시면 지금도 충분히 좋습니다!

넵, 둘 다 해봤는데 버튼이 넓어지면 보는데 다소 방해되는 것 같아서 일단 지금 상태로 머지하겠습니다!

@yoopark yoopark merged commit db049c1 into develop Oct 19, 2023
@yoopark yoopark deleted the feat/fab branch October 19, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

평가로그 검색 FAB 눈에 띄게 수정
2 participants