[Fix] 본과정 시작 전 유저에 대한 "본과정 시작한지" 카드 오류 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
그냥 |
|
뭔가 그렇게 바꿀 바에는 본과정 시작한지라는 이름 자체를 바꿔야 더 자연스럽지 않을까 싶어서 고민입니다. |
|
근데 -11 은 또 버그 같기도 해서요 ㅋㅋ |
|
그럼 그냥 본과정 시작일을 표시하고, 더 이전에 들어온 사람에게 볼드 처리할까요? |
|
그것보단 차라리 -11 일 이 나을 것 같습니다 |
|
본 과정 시작한게 기준이면 음수는 다 0으로 바꿔도 괜찮을 것 같아요 |
42sungwook
approved these changes
Sep 24, 2023
42sungwook
changed the title
42sungwook
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes
음수로 표현하는 것은 UI 상 좋지 않아보이지만, 마땅히 생각나는 대체 문구가 없어서 일단 두었습니다.
추후 develop 브랜치에서 아직 들어오지 않은 신규 유저에 대한 고려를 별도 이슈로 올리겠습니다.
Issue number and link