Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [Refactor] hoc 패턴 삭제 #233

Merged
merged 1 commit into from
Aug 7, 2023
Merged

♻️ [Refactor] hoc 패턴 삭제 #233

merged 1 commit into from
Aug 7, 2023

Conversation

yoopark
Copy link
Contributor

@yoopark yoopark commented Aug 7, 2023

Summary

HOC 패턴을 삭제했습니다.

Describe your changes

  • withHead : "팀명"처럼 useQuery를 통해 불러오는 데이터를 Head에 넣을 수 없는 문제 발생.
  • withFooter : if (loading) { return null; } 을 하면, 데이터가 로딩 중일 때 Footer가 위에 렌더링되었다가 아래로 내려가는 문제 발생.
  • withLoading / withError : 대시보드 데이터 로딩 뷰를 HOC로 빼려 했으나, 이게 오히려 구식 패턴이고, 지금처럼 useQuery Hook을 사용하는게 최신 패턴이었음.

Issue number and link

@yoopark yoopark added the enhancement New feature or request label Aug 7, 2023
@yoopark yoopark merged commit 1094633 into main Aug 7, 2023
@yoopark yoopark deleted the refactor/remove-hoc branch August 7, 2023 13:32
@42sungwook 42sungwook changed the title ♻️ refactor: hoc 패턴 삭제 ♻️ [Refactor] hoc 패턴 삭제 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

hoc 패턴 재고
1 participant